Skip to content

Refactor multiaddress creation #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
richard-ramos opened this issue Mar 22, 2022 · 0 comments · Fixed by #252
Closed

Refactor multiaddress creation #214

richard-ramos opened this issue Mar 22, 2022 · 0 comments · Fixed by #252

Comments

@richard-ramos
Copy link
Member

In #201 and #213 there's some code duplication as well as increased complexity in the way multiaddresses are handled when advertise addresses and/or ws/wss is used. Simplify this via the creation of a custom address factory that handles all these scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: js-waku / nwaku interop waku-org/go-waku
1 participant
@richard-ramos