Skip to content

hasSampledFeature confuses distinctions between predicates of sampling/samples, and final place on chain relating to FeatureOfInterest #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canwaf opened this issue Jun 5, 2025 · 3 comments

Comments

@canwaf
Copy link

canwaf commented Jun 5, 2025

In the 4 June 2025 update of SSN

isSampleOf has a Domain of Sample/SampleCollection and a Range of FeatureOfInterest to relate the Sample(Collection) to the feature of interest it is intended to be representative of.

hasSampledFeature has a Domain of Sample/SampleCollection with a Range of FeatureOfInterest, which is new and speaks of has ultimate sampled feature to relate the Sample(Collection) to the (ultimate) feature of interest.

In the Sampling Overview diagram, both isSampleOf and hasSampledFeature follow the same direction between Sample and FeatureOfinterest. And Sampling uses the predicate hasUltimateFeatureOfinterest for Domain Sampling to Range FeatureOfInterest.

It took me along while to mentally join isSampleOf and hasSampledFeature with the latter trying to accomplish the same end-of-chain benefit of hasUltimateFeatureOfInterest that Sampling enjoys. Instead of changing the verb tense to distinguish the intent between these two predicates, it would be better to mirror the established ultimate adjective: isUltimateSampleOf follows the pattern better.

Edit: isUltimateSampleOf doesn't convey the intended end-of-chain after brief reconsideration; however the confusion still exists.

@dr-shorthair
Copy link
Collaborator

Thanks @canwaf .

Yes, I had earlier considered isUltimateSampleOf and came to the same conclusion.
The semantics is more like isSampleOfUltimateFeatureOfInterest but that is one hell of a mouthful.
Maybe isSampleOfUltimately captures it?

@TallTed
Copy link
Member

TallTed commented Jun 12, 2025

Maybe isSampleOfUltimateFOI?

If not, I'd suggest isUltimatelySampleOf over isSampleOfUltimately.

@canwaf
Copy link
Author

canwaf commented Jun 16, 2025

isSampleOfUltimateFOI is my favoured option. But isUltimatelySampleOf with the domain in the docs clears it up too. All of the suggested alternatives I believe is an improvement.

Thank you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants