Skip to content

Should pending promise be abort if document isn't top-level? #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makotokato opened this issue May 7, 2025 · 1 comment
Open

Should pending promise be abort if document isn't top-level? #257

makotokato opened this issue May 7, 2025 · 1 comment

Comments

@makotokato
Copy link

In spec,

8.6 Handling unloading documents

Whenever the unloading document cleanup steps run with a document, the user agent MUST run the following steps:

  1. If document is not a top-level browsing context's active document, abort these steps.
  2. Run the fully unlock the screen orientation steps with document.

But the last test in active-lock.html is whether promise is aborted or not for iframe document. My understand is that iframe document isn't "top-level browsing context's active document", so this step is do nothing. So I confuse this WPT.

Should we abort pending promise even if document isn't top- level?

@makotokato
Copy link
Author

If this test is for 8.3.5.1, it will be followed. But after 8.3.6, I guess it has possible orphan case for this promise. I guess more check whether full active or not after 8.3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant