-
Notifications
You must be signed in to change notification settings - Fork 24
What is the scope of timings? #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think just work that needs to happen? But I agree that the spec is confusing... and I'm not sure what the correct wording is. It says "Each ECMAScript global environment has[...] a list of registered performance observer objects that is initially empty", so we need to tie that with the concept of marking paint timing for a Document. |
I believe these issues are addressed in the current spec language.
Do I understand correctly that you'd like us to modify "queue a PerformanceEntry" to also receive a document and handle observer registrations off of that? If so, seems like we should open that as an issue on PerformanceTimeline |
It's mostly fixed. One minor remaining issue is the sentences of the form "If this instance of update the rendering is the first paint of document". First paint is not properly defined on a per-
This looks to have been improved as well. In particular it smuggles in the global object pointer by consulting newEntry's relevant global object, and then it uses that to create all the objects in question. So this seems good to go. |
Yep, this is related to what I mentioned in #38.
I'm a smuggler :D this is fixed in Paint Timing and I'm tracking others in w3c/performance-timeline#162. |
Yeah, it seems like whatever will solve #38 will also resolve this. |
I believe this is closed by #82 |
As of whatwg/html#3923, the HTML event loop calls "mark paint timings" giving it a
Document
object.But the spec at https://w3c.github.io/paint-timing/ isn't very clear about how things are scoped. It should probably use the Document argument to make more precise statements like "If this instance of update the rendering is the first contentful paint", and to say in which realm to "Create a new PerformancePaintTiming object"
This problem extends to the called https://w3c.github.io/performance-timeline/#dfn-queue-a-performanceentry spec as well; it's not clear what "For each registered performance observer" means. It could mean any PerformanceObserver objects from any Document at all, or just the Document ones, or the same-origin Document ones...
The text was updated successfully, but these errors were encountered: