Skip to content

Commit 1c4300f

Browse files
Skip default lanes dup check (sonic-net#3489)
* Add namespace check for multiasic * Skip Default lane duplication check.
1 parent 317e649 commit 1c4300f

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

generic_config_updater/gu_common.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,8 @@ def validate_lanes(self, config_db):
239239
for port in port_to_lanes_map:
240240
lanes = port_to_lanes_map[port]
241241
for lane in lanes:
242-
if lane in existing:
242+
# default lane would be 0, it does not need validate duplication.
243+
if lane in existing and lane != '0':
243244
return False, f"'{lane}' lane is used multiple times in PORT: {set([port, existing[lane]])}"
244245
existing[lane] = port
245246
return True, None

tests/generic_config_updater/gu_common_test.py

+7
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,13 @@ def test_validate_lanes__same_valid_lanes_multi_ports_no_spaces__failure(self):
361361
}}
362362
self.validate_lanes(config, '67')
363363

364+
def test_validate_lanes_default_value_duplicate_check(self):
365+
config = {"PORT": {
366+
"Ethernet0": {"lanes": "0", "speed": "10000"},
367+
"Ethernet1": {"lanes": "0", "speed": "10000"},
368+
}}
369+
self.validate_lanes(config)
370+
364371
def validate_lanes(self, config_db, expected_error=None):
365372
# Arrange
366373
config_wrapper = gu_common.ConfigWrapper()

0 commit comments

Comments
 (0)