Skip to content

External templates break syntax highlighting #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThomasKientz opened this issue Jun 7, 2018 · 6 comments
Closed

External templates break syntax highlighting #813

ThomasKientz opened this issue Jun 7, 2018 · 6 comments
Labels
Milestone

Comments

@ThomasKientz
Copy link

ThomasKientz commented Jun 7, 2018

Info

  • Platform: macOS
  • Vetur version: 0.12.3
  • VS Code version: 1.23.1

Problem

<template 
  src="./mission.html" 
  lang="html"/>

<script>
//code not being highlight
<script>

Breaks syntax highlighting (and maybe formating too)

But this is using recommended vue's es-linting rules.

2 things is causing the break :

  • / inside src attribute.
  • multi lines
@ThomasKientz ThomasKientz changed the title Syntax highlighting breaks with external template External templates break syntax highlighting Jun 7, 2018
@octref
Copy link
Member

octref commented Jun 7, 2018

<template src="./mission.html"></template>

<script>
</script>

@octref octref closed this as completed Jun 7, 2018
@octref octref added the question label Jun 7, 2018
@ThomasKientz
Copy link
Author

ThomasKientz commented Jun 7, 2018

@octref This works but doesn't respect enforce self-closing style (vue/html-self-closing) from vue recommended style.

@octref
Copy link
Member

octref commented Jun 8, 2018

That does not concern the enclosing region divider. However the syntax highlight does have some problem now...

@octref octref reopened this Jun 8, 2018
@octref
Copy link
Member

octref commented Jun 8, 2018

I'll just make sure this works:

<template src="./mission.html" />

I will never support multiline.

@octref octref added grammar and removed question labels Aug 10, 2018
@octref octref added this to the quickfix milestone Aug 10, 2018
@octref
Copy link
Member

octref commented May 8, 2019

This is now supported:

image

Multi line is not possible without a lot of hacks, so I'll pass on that.

@octref octref modified the milestones: quickfix, April 2019 May 8, 2019
@octref octref closed this as completed in 18de9a6 May 8, 2019
@octref
Copy link
Member

octref commented May 8, 2019

Just to link to microsoft/vscode-textmate#32 on why mutiline is almost impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants