Skip to content

Bring in stylelint and stylefmt for style #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
octref opened this issue May 8, 2017 · 7 comments
Closed

Bring in stylelint and stylefmt for style #190

octref opened this issue May 8, 2017 · 7 comments

Comments

@octref
Copy link
Member

octref commented May 8, 2017

They seem to have best support for linting / formatting css/scss/sass/less/postcss.

@octref octref mentioned this issue May 10, 2017
12 tasks
@cannap
Copy link

cannap commented May 30, 2017

look at this https://github.com/morishitter/scssfmt :D

@glen-84
Copy link

glen-84 commented Jul 8, 2017

@octref In order to support sass-lint (I'm the author), does something have to be added to Vetur, or do you know of a way to add support via existing APIs?

@octref
Copy link
Member Author

octref commented Jul 9, 2017

@glen-84
Thanks a lot for your interest! I'm open to including it.

Take a look at https://github.com/vuejs/vetur/tree/master/server/src for modes/style/stylus/index. Basically each language is called a mode in Vetur and it's easy to add a default template mode for sass (currently we don't have one yet), and only implement its doValidation method which is for reporting lint errors.

Integrating sass should be pretty similar to integrating stylus (actually much easier since we only add linting here).

@octref
Copy link
Member Author

octref commented Aug 5, 2017

Seems sass-lint also has support for scss files. Maybe you can start form there.

@octref
Copy link
Member Author

octref commented Aug 5, 2017

@glen-84 Seems sass-lint also supports scss files. Maybe you can start from there since Vetur already has support for scss. See https://github.com/vuejs/vetur/blob/master/server/src/modes/style/index.ts

@octref
Copy link
Member Author

octref commented Aug 5, 2017

There is nothing to do for this issue so closing.

stylefmt is included in prettier and we'll include it.
For linting I'll open a new issue.

@octref octref closed this as completed Aug 5, 2017
@glen-84
Copy link

glen-84 commented Aug 6, 2017

@octref Apologies for the late reply. I would prefer to do something that doesn't rely directly on your extension, but instead is more generic to the framework (in this case Vue.js) in use.

I will investigate this more at a later date.

Thanks.

@zyy7259 zyy7259 mentioned this issue Nov 20, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants