Skip to content

Send Cancellation Token to TypeScript Language Server #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
octref opened this issue May 1, 2019 · 0 comments · Fixed by #2332
Closed

Send Cancellation Token to TypeScript Language Server #1263

octref opened this issue May 1, 2019 · 0 comments · Fixed by #2332
Labels
Milestone

Comments

@octref
Copy link
Member

octref commented May 1, 2019

Cancellation token is issued when the next operation happens. For example, when typing abc, Vetur will query TS Server for diagnostics on a, ab, abc. If typing of abc finishes before a's diagnostic request is responded, vscode-languageclient should send a cancellation token.

In this case, Vetur should forward that cancellation token to TS Server so it can stop computing outdated diagnostics/auto-completion. This should reduce a lot of CPU/memory usage from VLS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant