Fix #2304

Author: octref

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ### 0.28.0
 
+- Fix completing prop name completes with extra `:`. #2304.
 - Add `vetur.languageFeatures.codeActions` option to disable codeAction. #2150
 - Let VTI load default VLS config. #2274.
 - Make `prettier` default formatter for HTML as prettyhtml is no longer actively maintained. #2291.

server/src/modes/template/services/htmlCompletion.ts

@@ -154,6 +154,9 @@ export function doComplete(
         if (type !== 'v' && value.length) {
           codeSnippet = codeSnippet + value;
         }
+        if ((filterPrefix === ':' && codeSnippet[0] === ':') || (filterPrefix === '@' && codeSnippet[0] === '@')) {
+          codeSnippet = codeSnippet.slice(1);
+        }
         result.items.push({
           label: attribute,
           kind: type === 'event' ? CompletionItemKind.Function : CompletionItemKind.Value,

test/completionHelper.ts

@@ -12,6 +12,10 @@ export interface ExpectedCompletionItem extends CompletionItem {
    * Documentation has to include this string
    */
   documentationFragment?: string;
+  /**
+   * Insertion text edit's string
+   */
+  insertTextValue?: string;
 }
 
 export async function testCompletion(
@@ -99,6 +103,14 @@ export async function testCompletion(
           );
         }
       }
+
+      if (ei.insertTextValue) {
+        if (match.insertText instanceof vscode.SnippetString) {
+          assert.strictEqual(match.insertText.value, ei.insertTextValue);
+        } else {
+          assert.strictEqual(match.insertText, ei.insertTextValue);
+        }
+      }
     }
   });
 }

test/lsp/features/completion/template.test.ts

@@ -71,8 +71,18 @@ describe('Should autocomplete for <template>', () => {
 
       await testCompletion(parentUri, position(4, 6), ['ChildComp']);
 
-      await testCompletion(parentUri, position(2, 15), [':attr-a']);
-      await testCompletion(parentUri, position(3, 16), [':attr-a']);
+      await testCompletion(parentUri, position(2, 15), [
+        {
+          label: ':attr-a',
+          insertTextValue: ':attr-a="$1"'
+        }
+      ]);
+      await testCompletion(parentUri, position(3, 16), [
+        {
+          label: ':attr-a',
+          insertTextValue: 'attr-a="$1"'
+        }
+      ]);
 
       // set it back
       await c.update('vetur.completion.tagCasing', undefined, ConfigurationTarget.Global);