Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom delimiters in child contexts #90

Merged
merged 4 commits into from
Jan 18, 2022
Merged

fix: custom delimiters in child contexts #90

merged 4 commits into from
Jan 18, 2022

Conversation

halivert
Copy link
Contributor

@halivert halivert commented Oct 3, 2021

Move delimiters and delimitersRE options in context to overwrite it with parent context.

@shahriar350
Copy link

can we add our own delimiter in petite-vue?

@halivert
Copy link
Contributor Author

halivert commented Oct 3, 2021

Yes @shahriar350 there is support for it, see #41 and eda903c

@halivert halivert changed the title Fix delimiters in child contexts fix: custom delimiters in child contexts Nov 4, 2021
@PerpetualWar
Copy link

This is a big problem when trying to use PetiteVue in existing template language , like django template (both vue and django template use {{}} delimiters as as a interpolation).

Any possible workaround for this, as this basically prevents me from using petite-vue altogether?

@halivert
Copy link
Contributor Author

@PerpetualWar You could compile your own version of petite-vue with the updates stated in this PR, and use it. I'm not familiar with Django, but for example Laravel could use different tags for blade and other javascript frameworks.

@PerpetualWar
Copy link

@PerpetualWar You could compile your own version of petite-vue with the updates stated in this PR, and use it. I'm not familiar with Django, but for example Laravel could use different tags for blade and other javascript frameworks.

How would I compile modified version?

@halivert
Copy link
Contributor Author

halivert commented Nov 27, 2021

@PerpetualWar Steps:

  • gh repo clone halivert/petite-vue - Clone the repo.
  • git switch fix-delimiters-in-child-contexts - Switch to the version with the fixes.
  • yarn - Install dependencies.
  • yarn build - Build library.
  • ???
  • Profit

Results are in the dist folder, created by the last command (yarn build).

@muety
Copy link

muety commented Dec 16, 2021

Would be awesome to have this merged as soon as possible! 👍

@yyx990803 yyx990803 merged commit 1bbd4d1 into vuejs:main Jan 18, 2022
@halivert halivert deleted the fix-delimiters-in-child-contexts branch January 18, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants