Skip to content

Commit 69c770a

Browse files
committed
LogRecord args is tuple
Closes #28.
1 parent a54237d commit 69c770a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
* LogRecord takes tuple as `args`, provide an empty one and not a `None` (#28).
2+
13
# 0.8.2
24

35
* Allow pyo3 0.19.

src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
//! ```rust
3131
//! use log::info;
3232
//! use pyo3::prelude::*;
33-
//! use pyo3::wrap_pyfunction;
3433
//!
3534
//! #[pyfunction]
3635
//! fn log_something() {
@@ -163,6 +162,7 @@ use std::sync::Arc;
163162
use arc_swap::ArcSwap;
164163
use log::{Level, LevelFilter, Log, Metadata, Record, SetLoggerError};
165164
use pyo3::prelude::*;
165+
use pyo3::types::PyTuple;
166166

167167
/// A handle into a [`Logger`], able to reset its caches.
168168
///
@@ -421,8 +421,8 @@ impl Logger {
421421
record.file(),
422422
record.line().unwrap_or_default(),
423423
msg,
424-
&none, // args
425-
&none, // exc_info
424+
PyTuple::empty(py), // args
425+
&none, // exc_info
426426
),
427427
)?;
428428
logger.call_method1("handle", (record,))?;

0 commit comments

Comments
 (0)