Skip to content

Commit b30ffc3

Browse files
authored
Merge pull request #83 from volcano-sh/bug/fix_left_over
Fix issue raised from previous MR
2 parents 3348790 + 92445b2 commit b30ffc3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ build them locally with the command:
6868

6969
```
7070
cd $GOPATH/src/volcano.sh/volcano
71-
make docker
71+
make images
7272
7373
## Verify your images
7474
# docker images

hack/run-e2e-kind.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ function install-volcano {
5757
docker pull ${MPI_EXAMPLE_IMAGE}
5858

5959
echo "Loading docker images into kind cluster"
60-
kind load docker-image ${IMAGE}-controllers:${TAG} ${CLUSTER_CONTEXT}
61-
kind load docker-image ${IMAGE}-scheduler:${TAG} ${CLUSTER_CONTEXT}
62-
kind load docker-image ${IMAGE}-admission:${TAG} ${CLUSTER_CONTEXT}
60+
kind load docker-image ${IMAGE_PREFIX}-controllers:${TAG} ${CLUSTER_CONTEXT}
61+
kind load docker-image ${IMAGE_PREFIX}-scheduler:${TAG} ${CLUSTER_CONTEXT}
62+
kind load docker-image ${IMAGE_PREFIX}-admission:${TAG} ${CLUSTER_CONTEXT}
6363
kind load docker-image ${MPI_EXAMPLE_IMAGE} ${CLUSTER_CONTEXT}
6464

6565
echo "Install volcano plugin into cluster...."

installer/chart/volcano/plugins/gen-admission-secret/gen-admission-secret.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ for x in $(seq 15); do
116116
sleep 1
117117
done
118118
if [[ ${serverCert} == '' ]]; then
119-
echo "ERROR: After approving csr ${csrName}, the signed certificate did not appear on the resource. Giving up after 10 attempts." >&2
119+
echo "ERROR: After approving csr ${csrName}, the signed certificate did not appear on the resource. Giving up after 15 attempts." >&2
120120
exit 1
121121
fi
122122
echo ${serverCert} | openssl base64 -d -A -out ${tmpdir}/server-cert.pem

0 commit comments

Comments
 (0)