Add fabric_datastore_vsphere resource

Add a new vra_fabric_datastore_vsphere resource

Signed-off-by: Ferran Rodenas <[email protected]>

Author: frodenas

examples/fabric_datastore_vsphere/README.md

@@ -0,0 +1,54 @@
+# fabric datastore vSphere example
+
+**__NOTE: THIS RESOURCE TYPE MUST BE IMPORTED. ATTEMPTING TO CREATE IT WILL ERROR__ **
+
+These resources (fabric datasource vSphere) are discovered in vRA(C) as part of creating a Cloud Account and can not therefore be "created" or "destroyed" in a traditional sense.
+
+This is an example on how to import a fabric datastore vSphere resource into terraform and then manage settings on it.
+
+## Getting Started
+
+There are variables which need to be added to a `terraform.tfvars` file:
+
+* `url` - The base url for API operations
+* `refresh_token` - The refresh token for API operations
+* `insecure` - Specify whether to validate TLS certificates
+
+To facilitate adding these variables, a sample tfvars file can be copied first:
+
+```shell
+cp terraform.tfvars.sample terraform.tfvars
+```
+
+This examples assumes a cloud account is already set up.
+
+To import the resource you must find the ID of the fabric datastore vSphere. There are a couple of way this ID can be aquired:
+
+1. Via API calls
+2. Viewing the object in a browser and pulling the ID from the url (ex value: `6c78facd-2ba0-4e06-b6f6-5682dec55056`)
+
+Once the information is added to `terraform.tfvars` the resource can be imported and the manage via:
+
+```shell
+terraform import vra_fabric_datastore_vsphere.this <fabricDatastorevSphereID>
+```
+
+If the import is successful output from the command should resemble
+
+```shell
+vra_fabric_datastore_vsphere.this: Importing from ID "<fabricDatastorevSphereID>"...
+vra_fabric_datastore_vsphere.this: Import prepared!
+  Prepared vra_fabric_datastore_vsphere for import
+vra_fabric_datastore_vsphere.this: Refreshing state... [id=<fabricDatastorevSphereID>]
+
+Import successful!
+
+The resources that were imported are shown above. These resources are now in
+your Terraform state and will henceforth be managed by Terraform
+```
+
+To apply your settings you can now perform an apply comand:
+
+```shell
+terraform apply
+```

examples/fabric_datastore_vsphere/main.tf

@@ -0,0 +1,13 @@
+provider "vra" {
+  url           = var.url
+  refresh_token = var.refresh_token
+  insecure      = var.insecure
+}
+
+resource "vra_fabric_datastore_vsphere" "this" {
+  tags {
+    key   = "foo"
+    value = "bar"
+  }
+}
+

examples/fabric_datastore_vsphere/terraform.tfvars.sample

@@ -0,0 +1,3 @@
+url = ""
+refresh_token = ""
+insecure = ""

examples/fabric_datastore_vsphere/variables.tf

@@ -0,0 +1,11 @@
+variable "url" {
+  description = "The base url for API operations"
+}
+
+variable "refresh_token" {
+  description = "The refresh token for API operations"
+}
+
+variable "insecure" {
+  description = "Specify whether to validate TLS certificates"
+}

vra/provider.go

@@ -105,6 +105,7 @@ func Provider() *schema.Provider {
 			"vra_content_source":             resourceContentSource(),
 			"vra_deployment":                 resourceDeployment(),
 			"vra_fabric_compute":             resourceFabricCompute(),
+			"vra_fabric_datastore_vsphere":   resourceFabricDatastoreVsphere(),
 			"vra_fabric_network_vsphere":     resourceFabricNetworkVsphere(),
 			"vra_flavor_profile":             resourceFlavorProfile(),
 			"vra_image_profile":              resourceImageProfile(),

vra/provider_test.go

@@ -545,3 +545,20 @@ func testAccPreCheckFabricCompute(t *testing.T) {
 		}
 	}
 }
+
+func testAccPreCheckFabricDatastoreVsphere(t *testing.T) {
+	if os.Getenv("VRA_REFRESH_TOKEN") == "" && os.Getenv("VRA_ACCESS_TOKEN") == "" {
+		t.Fatal("VRA_REFRESH_TOKEN or VRA_ACCESS_TOKEN must be set for acceptance tests")
+	}
+
+	envVars := [...]string{
+		"VRA_URL",
+		"VRA_FABRIC_DATASTORE_VSPHERE_NAME",
+	}
+
+	for _, name := range envVars {
+		if v := os.Getenv(name); v == "" {
+			t.Fatalf("%s must be set for acceptance tests\n", name)
+		}
+	}
+}

vra/resource_fabric_datastore_vsphere.go

@@ -0,0 +1,153 @@
+package vra
+
+import (
+	"context"
+	"errors"
+
+	"github.com/vmware/vra-sdk-go/pkg/client/fabric_vsphere_datastore"
+	"github.com/vmware/vra-sdk-go/pkg/models"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func resourceFabricDatastoreVsphere() *schema.Resource {
+	return &schema.Resource{
+		CreateContext: resourceFabricDatastoreVsphereCreate,
+		ReadContext:   resourceFabricDatastoreVsphereRead,
+		UpdateContext: resourceFabricDatastoreVsphereUpdate,
+		DeleteContext: resourceFabricDatastoreVsphereDelete,
+		Importer: &schema.ResourceImporter{
+			StateContext: schema.ImportStatePassthroughContext,
+		},
+
+		Schema: map[string]*schema.Schema{
+			"cloud_account_ids": {
+				Type:        schema.TypeSet,
+				Computed:    true,
+				Description: "Set of ids of the cloud accounts this entity belongs to.",
+				Elem: &schema.Schema{
+					Type: schema.TypeString,
+				},
+			},
+			"created_at": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Date when the entity was created. The date is in ISO 8601 and UTC.",
+			},
+			"description": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "A human-friendly description.",
+			},
+			"external_id": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "External entity Id on the provider side.",
+			},
+			"external_region_id": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Id of datacenter in which the datastore is present.",
+			},
+			"free_size_gb": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Indicates free size available in datastore.",
+			},
+			"links": linksSchema(),
+			"name": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "A human-friendly name used as an identifier for the vSphere fabric datastore resource instance.",
+			},
+			"org_id": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The id of the organization this entity belongs to.",
+			},
+			"owner": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Email of the user that owns the entity.",
+			},
+			"tags": tagsSchema(),
+			"type": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Type of datastore.",
+			},
+			"updated_at": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Date when the entity was last updated. The date is ISO 8601 and UTC.",
+			},
+		},
+	}
+}
+
+func resourceFabricDatastoreVsphereCreate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
+	return diag.FromErr(errors.New("vra_fabric_datastore_vsphere resources are only importable"))
+}
+
+func resourceFabricDatastoreVsphereRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
+	apiClient := m.(*Client).apiClient
+
+	id := d.Id()
+
+	resp, err := apiClient.FabricvSphereDatastore.GetFabricVSphereDatastore(fabric_vsphere_datastore.NewGetFabricVSphereDatastoreParams().WithID(id))
+	if err != nil {
+		switch err.(type) {
+		case *fabric_vsphere_datastore.GetFabricVSphereDatastoreNotFound:
+			return diag.Errorf("vSphere fabric datastore '%s' not found", id)
+		default:
+			// nop
+		}
+		return diag.FromErr(err)
+	}
+
+	fabricVsphereDatastore := resp.GetPayload()
+	d.SetId(*fabricVsphereDatastore.ID)
+	d.Set("cloud_account_ids", fabricVsphereDatastore.CloudAccountIds)
+	d.Set("created_at", fabricVsphereDatastore.CreatedAt)
+	d.Set("description", fabricVsphereDatastore.Description)
+	d.Set("external_id", fabricVsphereDatastore.ExternalID)
+	d.Set("external_region_id", fabricVsphereDatastore.ExternalRegionID)
+	d.Set("free_size_gb", fabricVsphereDatastore.FreeSizeGB)
+	d.Set("name", fabricVsphereDatastore.Name)
+	d.Set("org_id", fabricVsphereDatastore.OrgID)
+	d.Set("owner", fabricVsphereDatastore.Owner)
+	d.Set("type", fabricVsphereDatastore.Type)
+	d.Set("updated_at", fabricVsphereDatastore.UpdatedAt)
+
+	if err := d.Set("links", flattenLinks(fabricVsphereDatastore.Links)); err != nil {
+		return diag.Errorf("error setting vSphere fabric datastore links - error: %#v", err)
+	}
+
+	if err := d.Set("tags", flattenTags(fabricVsphereDatastore.Tags)); err != nil {
+		return diag.Errorf("error setting vSphere fabric datastore tags - error: %v", err)
+	}
+
+	return nil
+}
+
+func resourceFabricDatastoreVsphereUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
+	apiClient := m.(*Client).apiClient
+
+	id := d.Id()
+
+	fabricVsphereDatastoreSpecification := &models.FabricVsphereDatastoreSpecification{
+		Tags: expandTags(d.Get("tags").(*schema.Set).List()),
+	}
+
+	_, err := apiClient.FabricvSphereDatastore.UpdateFabricVsphereDatastore(fabric_vsphere_datastore.NewUpdateFabricVsphereDatastoreParams().WithID(id).WithBody(fabricVsphereDatastoreSpecification))
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	return resourceFabricDatastoreVsphereRead(ctx, d, m)
+}
+
+func resourceFabricDatastoreVsphereDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
+	return nil
+}

vra/resource_fabric_datastore_vsphere_test.go

@@ -0,0 +1,70 @@
+package vra
+
+import (
+	"fmt"
+	"os"
+	"regexp"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
+	"github.com/vmware/vra-sdk-go/pkg/client/fabric_vsphere_datastore"
+)
+
+func TestAccVRAFabricDatastoreVsphere_importBasic(t *testing.T) {
+	resourceName := "vra_fabric_datastore_vsphere"
+	fabricDatastoreVsphereID := os.Getenv("VRA_FABRIC_DATASTORE_VSPHERE_ID")
+
+	checkFn := func(s []*terraform.InstanceState) error {
+		if len(s) != 1 {
+			return fmt.Errorf("expected 1 state %#v", s)
+		}
+
+		fabricDatastoreVsphereState := s[0]
+		if fabricDatastoreVsphereID != fabricDatastoreVsphereState.ID {
+			return fmt.Errorf("expected fabric datastore vSphere ID of %s,%s received instead", fabricDatastoreVsphereID, fabricDatastoreVsphereState.ID)
+		}
+		return nil
+	}
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheckFabricDatastoreVsphere(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckVRAFabricDatastoreVsphereDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config:      testAccCheckVRAFabricDatastoreVsphereConfig(),
+				ExpectError: regexp.MustCompile("vra_fabric_datastore_vsphere resources are only importable"),
+			},
+			{
+				Config:           testAccCheckVRAFabricDatastoreVsphereConfig(),
+				ResourceName:     resourceName,
+				ImportState:      true,
+				ImportStateId:    fabricDatastoreVsphereID,
+				ImportStateCheck: checkFn,
+			},
+		},
+	})
+}
+
+func testAccCheckVRAFabricDatastoreVsphereDestroy(s *terraform.State) error {
+	apiClient := testAccProviderVRA.Meta().(*Client).apiClient
+
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type == "vra_fabric_datastore_vsphere" {
+			if _, err := apiClient.FabricvSphereDatastore.GetFabricVSphereDatastore(fabric_vsphere_datastore.NewGetFabricVSphereDatastoreParams().WithID(rs.Primary.ID)); err == nil {
+				return fmt.Errorf("Resource 'vra_fabric_datastore_vsphere' with id `%s` does not exist", rs.Primary.ID)
+			}
+		}
+
+	}
+
+	return nil
+}
+
+func testAccCheckVRAFabricDatastoreVsphereConfig() string {
+	fabricDatastoreVsphereName := os.Getenv("VRA_FABRIC_DATASTORE_VSPHERE_NAME")
+	return fmt.Sprintf(`
+		resource "vra_fabric_datastore_vsphere" "this" {
+			name = "%s"
+		}`, fabricDatastoreVsphereName)
+}