Fix delete deployment when there is an error

Signed-off-by: Ferran Rodenas <[email protected]>

Author: frodenas

vra/resource_deployment.go

@@ -1103,7 +1103,10 @@ func deploymentActionStatusRefreshFunc(apiClient client.MulticloudIaaS, deployme
 func deploymentDeleteStatusRefreshFunc(apiClient client.MulticloudIaaS, id string) resource.StateRefreshFunc {
 	return func() (interface{}, string, error) {
 		ret, err := apiClient.Deployments.GetDeploymentByIDUsingGET(
-			deployments.NewGetDeploymentByIDUsingGETParams().WithDeploymentID(strfmt.UUID(id)))
+			deployments.NewGetDeploymentByIDUsingGETParams().
+				WithDeploymentID(strfmt.UUID(id)).
+				WithExpandLastRequest(withBool(true)).
+				WithAPIVersion(withString(DeploymentsAPIVersion)))
 		if err != nil {
 			switch err.(type) {
 			case *deployments.GetDeploymentByIDUsingGETNotFound:
@@ -1113,7 +1116,17 @@ func deploymentDeleteStatusRefreshFunc(apiClient client.MulticloudIaaS, id strin
 			}
 		}
 
-		return [...]string{id}, reflect.TypeOf(ret).String(), nil
+		status := ret.Payload.Status
+		switch status {
+		case models.DeploymentStatusDELETEINPROGRESS:
+			return [...]string{id}, reflect.TypeOf(ret).String(), nil
+		case models.DeploymentStatusDELETESUCCESSFUL:
+			return [...]string{id}, reflect.TypeOf(ret).String(), nil
+		case models.DeploymentStatusDELETEFAILED:
+			return [...]string{id}, reflect.TypeOf(ret).String(), fmt.Errorf(ret.Payload.LastRequest.Details)
+		default:
+			return [...]string{id}, reflect.TypeOf(ret).String(), fmt.Errorf("deploymentStatusRefreshFunc: unknown status %v", status)
+		}
 	}
 }