Add MSI Support for Azure plugin.

yanggang · yanggang · commit a42938dbfee9 · 2023-10-10T15:50:15.000+01:00
Signed-off-by: yanggang &lt;gang.yang@daocloud.io&gt;
diff --git a/changelogs/unreleased/6938-yanggangtony b/changelogs/unreleased/6938-yanggangtony
@@ -0,0 +1 @@
+Add MSI Support for Azure plugin.
diff --git a/pkg/util/azure/credential.go b/pkg/util/azure/credential.go
@@ -129,5 +129,14 @@ func newConfigCredential(creds map[string]string, options configCredentialOption
 		return nil, errors.Errorf("%s is required", CredentialKeyPassword)
 	}
 
+	//msiEndpoint
+	msiEndpoint := creds[CredentialMSIENDPOINT]
+	identityEndpoint := creds[CredentialIDENTITYENDPOINT]
+
+	if msiEndpoint != "" || identityEndpoint != "" {
+		o := &azidentity.ManagedIdentityCredentialOptions{ClientOptions: options.ClientOptions, ID: azidentity.ClientID(clientID)}
+		return azidentity.NewManagedIdentityCredential(o)
+	}
+
 	return nil, errors.New("incomplete credential configuration. Only AZURE_TENANT_ID and AZURE_CLIENT_ID are set")
 }
diff --git a/pkg/util/azure/util.go b/pkg/util/azure/util.go
@@ -49,6 +49,12 @@ const (
 	CredentialKeyUsername                   = "AZURE_USERNAME"                      // #nosec
 	CredentialKeyPassword                   = "AZURE_PASSWORD"                      // #nosec
 
+	CredentialIMDSENDPOINT             = "IMDS_ENDPOINT"              // #nosec
+	CredentialIDENTITYENDPOINT         = "IDENTITY_ENDPOINT"          // #nosec
+	CredentialIDENTITYHEADER           = "IDENTITY_HEADER"            // #nosec
+	CredentialIDENTITYSERVERTHUMBPRINT = "IDENTITY_SERVER_THUMBPRINT" // #nosec
+	CredentialMSIENDPOINT              = "MSI_ENDPOINT"               // #nosec
+
 	credentialFile = "credentialsFile"
 )
 

Original file line number	Diff line number	Diff line change
`@@ -129,5 +129,14 @@ func newConfigCredential(creds map[string]string, options configCredentialOption`
`129`	`129`	`return nil, errors.Errorf("%s is required", CredentialKeyPassword)`
`130`	`130`	`}`
`131`	`131`
	`132`	`+ //msiEndpoint`
	`133`	`+ msiEndpoint := creds[CredentialMSIENDPOINT]`
	`134`	`+ identityEndpoint := creds[CredentialIDENTITYENDPOINT]`
	`135`	`+`
	`136`	`+ if msiEndpoint != "" \|\| identityEndpoint != "" {`
	`137`	`+ o := &azidentity.ManagedIdentityCredentialOptions{ClientOptions: options.ClientOptions, ID: azidentity.ClientID(clientID)}`
	`138`	`+ return azidentity.NewManagedIdentityCredential(o)`
	`139`	`+ }`
	`140`	`+`
`132`	`141`	`return nil, errors.New("incomplete credential configuration. Only AZURE_TENANT_ID and AZURE_CLIENT_ID are set")`
`133`	`142`	`}`