Added feedback messages for successful execution of plugin commands (#3291)

Author: saji-pivotal

cli/core/pkg/command/discovery_source.go

@@ -7,6 +7,8 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/aunum/log"
+
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
@@ -129,6 +131,7 @@ var addDiscoverySourceCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
+		log.Successf("successfully added discovery source %s", discoverySourceName)
 		return nil
 	},
 }
@@ -175,6 +178,7 @@ var updateDiscoverySourceCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
+		log.Successf("updated discovery source %s", discoveryName)
 		return nil
 	},
 }
@@ -211,6 +215,7 @@ var deleteDiscoverySourceCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
+		log.Successf("deleted discovery source %s", discoveryName)
 		return nil
 	},
 }

cli/core/pkg/command/plugin_manager.go

@@ -366,7 +366,11 @@ var upgradePluginCmd = &cobra.Command{
 
 		versionSelector := repo.VersionSelector()
 		err = cli.UpgradePlugin(pluginName, plugin.FindVersion(versionSelector), repo)
-		return
+		if err != nil {
+			return err
+		}
+		log.Successf("successfully upgraded plugin %s", pluginName)
+		return nil
 	},
 }
 
@@ -402,8 +406,11 @@ var deletePluginCmd = &cobra.Command{
 		}
 
 		err = cli.DeletePlugin(pluginName)
-
-		return
+		if err != nil {
+			return err
+		}
+		log.Successf("successfully deleted plugin %s", pluginName)
+		return nil
 	},
 }
 
@@ -412,9 +419,20 @@ var cleanPluginCmd = &cobra.Command{
 	Short: "Clean the plugins",
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
 		if config.IsFeatureActivated(config.FeatureContextAwareCLIForPlugins) {
-			return pluginmanager.Clean()
+			err = pluginmanager.Clean()
+			if err != nil {
+				return err
+			}
+			log.Success("successfully cleaned up all plugins")
+			return nil
 		}
-		return cli.Clean()
+
+		err = cli.Clean()
+		if err != nil {
+			return err
+		}
+		log.Success("successfully cleaned up all plugins")
+		return nil
 	},
 }
 

cli/core/pkg/command/repo.go

@@ -6,6 +6,8 @@ package command
 import (
 	"fmt"
 
+	"github.com/aunum/log"
+
 	"github.com/spf13/cobra"
 
 	configv1alpha1 "github.com/vmware-tanzu/tanzu-framework/apis/config/v1alpha1"
@@ -104,6 +106,7 @@ var addRepoCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
+		log.Successf("successfully added repository %s", pluginRepo.GCPPluginRepository.Name)
 		return nil
 	},
 }
@@ -152,6 +155,7 @@ var updateRepoCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
+		log.Successf("successfully updated repository configuration for %s", repoName)
 		return nil
 	},
 }
@@ -191,6 +195,7 @@ var deleteRepoCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
+		log.Successf("successfully deleted repository %s", repoName)
 		return nil
 	},
 }