Fix typos and clean up (#938)

* Remove old binaries from before trigger controller refactor

* Recompile kubeless.yaml when kubeless-non-rbac.jsonnet changes

* Put time in RFC3339 format

* Fix typos in documentation

* Warn instead of returning an error for empty handler and body

* Test for RFC3339 timestamp

Author: dannyqiu

Makefile

@@ -38,7 +38,7 @@ binary-cross:
 
 all-yaml: kubeless.yaml kubeless-non-rbac.yaml kubeless-openshift.yaml kafka-zookeeper.yaml
 
-kubeless.yaml: kubeless.jsonnet
+kubeless.yaml: kubeless.jsonnet kubeless-non-rbac.jsonnet
 
 kubeless-non-rbac.yaml: kubeless-non-rbac.jsonnet
 

cmd/kubeless/function/call.go

@@ -97,7 +97,7 @@ var callCmd = &cobra.Command{
 			logrus.Fatalf("Unable to generate ID %v", err)
 		}
 		req.SetHeader("event-id", eventID)
-		req.SetHeader("event-time", timestamp.String())
+		req.SetHeader("event-time", timestamp.Format(time.RFC3339))
 		req.SetHeader("event-namespace", "cli.kubeless.io")
 		res, err := req.Do().Raw()
 		if err != nil {

cmd/kubeless/trigger/kafka/create.go

@@ -113,7 +113,7 @@ var createCmd = &cobra.Command{
 func init() {
 	createCmd.Flags().StringP("namespace", "n", "", "Specify namespace for the kafka trigger")
 	createCmd.Flags().StringP("trigger-topic", "", "", "Specify topic to listen to in Kafka broker")
-	createCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. -function-selector key1=value1,key2=value2)")
+	createCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. --function-selector key1=value1,key2=value2)")
 	createCmd.MarkFlagRequired("trigger-topic")
 	createCmd.MarkFlagRequired("function-selector")
 	createCmd.Flags().Bool("dryrun", false, "Output JSON manifest of the function without creating it")

cmd/kubeless/trigger/kafka/update.go

@@ -107,7 +107,7 @@ var updateCmd = &cobra.Command{
 func init() {
 	updateCmd.Flags().StringP("namespace", "n", "", "Specify namespace for the function")
 	updateCmd.Flags().StringP("trigger-topic", "", "", "Specify topic to listen to in Kafka broker")
-	updateCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. -function-selector key1=value1,key2=value2)")
+	updateCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. --function-selector key1=value1,key2=value2)")
 	updateCmd.Flags().Bool("dryrun", false, "Output JSON manifest of the function without creating it")
 	updateCmd.Flags().StringP("output", "o", "yaml", "Output format")
 }

cmd/kubeless/trigger/nats/create.go

@@ -114,7 +114,7 @@ var createCmd = &cobra.Command{
 func init() {
 	createCmd.Flags().StringP("namespace", "n", "", "Specify namespace for the NATS trigger")
 	createCmd.Flags().StringP("trigger-topic", "", "", "Specify topic to listen to in NATS")
-	createCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. -function-selector key1=value1,key2=value2)")
+	createCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. --function-selector key1=value1,key2=value2)")
 	createCmd.MarkFlagRequired("trigger-topic")
 	createCmd.MarkFlagRequired("function-selector")
 	createCmd.Flags().Bool("dryrun", false, "Output JSON manifest of the function without creating it")

cmd/kubeless/trigger/nats/update.go

@@ -107,7 +107,7 @@ var updateCmd = &cobra.Command{
 func init() {
 	updateCmd.Flags().StringP("namespace", "n", "", "Specify namespace for the NATS trigger")
 	updateCmd.Flags().StringP("trigger-topic", "", "", "Specify topic to listen to in NATS")
-	updateCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. -function-selector key1=value1,key2=value2)")
+	updateCmd.Flags().StringP("function-selector", "", "", "Selector (label query) to select function on (e.g. --function-selector key1=value1,key2=value2)")
 	updateCmd.Flags().Bool("dryrun", false, "Output JSON manifest of the function without creating it")
 	updateCmd.Flags().StringP("output", "o", "yaml", "Output format")
 }

docs/advanced-function-deployment.md

@@ -8,6 +8,9 @@ kind: Function
 metadata:
   name: get-python
   namespace: default
+  label:
+    created-by: kubeless
+    function: get-python
 spec:
   runtime: python2.7
   timeout: "180"

examples/Makefile

@@ -173,7 +173,7 @@ post-go-verify:
 	# Verify event context
 	logs=`kubectl logs -l function=post-go`; \
 	echo $$logs | grep -q "it.*alive" && \
-	echo $$logs | grep -q "UTC" && \
+	echo $$logs | grep -q "Z" && \
 	echo $$logs | grep -q "application/json" && \
 	echo $$logs | grep -q "cli.kubeless.io"
 
@@ -305,7 +305,7 @@ post-python-verify:
 	# Verify event context
 	logs=`kubectl logs -l function=post-python`; \
 	echo $$logs | grep -q "it.*alive" && \
-	echo $$logs | grep -q "event-time.*UTC" && \
+	echo $$logs | grep -q "event-time.*Z" && \
 	echo $$logs | grep -q "event-type.*application/json" && \
 	echo $$logs | grep -q "event-namespace.*cli.kubeless.io" && \
 	echo $$logs | grep -q "event-id.*"
@@ -325,7 +325,7 @@ post-nodejs-verify:
 	# Verify event context
 	logs=`kubectl logs -l function=post-nodejs`; \
 	echo $$logs | grep -q "it.*alive" && \
-	echo $$logs | grep -q "event-time.*UTC" && \
+	echo $$logs | grep -q "event-time.*Z" && \
 	echo $$logs | grep -q "event-type.*application/json" && \
 	echo $$logs | grep -q "event-namespace.*cli.kubeless.io" && \
 	echo $$logs | grep -q "event-id.*"
@@ -338,7 +338,7 @@ post-ruby-verify:
 	# Verify event context
 	logs=`kubectl logs -l function=post-ruby`; \
 	echo $$logs | grep -q "it.*alive" && \
-	echo $$logs | grep -q "event-time.*UTC" && \
+	echo $$logs | grep -q "event-time.*Z" && \
 	echo $$logs | grep -q "event-type.*application/json" && \
 	echo $$logs | grep -q "event-namespace.*cli.kubeless.io" && \
 	echo $$logs | grep -q "event-id.*"

pkg/controller/function_controller.go

@@ -230,7 +230,7 @@ func (c *FunctionController) processItem(key string) error {
 			c.logger.Errorf("Failed to remove function controller as finalizer to Function Obj: %s object due to: %v: ", key, err)
 			return err
 		}
-		c.logger.Infof("Function object %s has been successfully processed and marked for deleteion", key)
+		c.logger.Infof("Function object %s has been successfully processed and marked for deletion", key)
 		return nil
 	}
 

pkg/utils/kubelessutil.go

@@ -641,6 +641,8 @@ func EnsureFuncDeployment(client kubernetes.Interface, funcObj *kubelessApi.Func
 				Value: dpm.Spec.Template.Spec.Containers[0].Resources.Limits.Memory().String(),
 			},
 		)
+	} else {
+		logrus.Warn("Expected non-empty handler and non-empty function content")
 	}
 
 	dpm.Spec.Template.Spec.Containers[0].Env = append(dpm.Spec.Template.Spec.Containers[0].Env,