-
Notifications
You must be signed in to change notification settings - Fork 103
. #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do the respective context menu actions work? |
Copying with CMD+C works when viewing an email but not when composing (writing) one. It works if you use the context menu though. Maybe if the context menu actions in the composing window get CMD+C/V assigned it might work. |
According to the documentation to make hotkeys work on macOS I will need to add respective actions to the main app menu, not to the context menu, so it would be a sort of app global hotkeys. I didn't want to extend the main app menu and tried to go with a workaround which as we can see doesn't work fully properly. So going to extend the main app menu for macOS only. It still might not be working due to opened Electron bugs (like this and this), but we better try it in our own. |
Yeah, never programmed with electron only with Qt so that was just a guess. I think as long as the context menus work it's usable, thanks |
It's usable, but I'd like to close known bugs before releasing the final v2 version. |
@joshirio can you try updated build in the same Dropbox folder. There are two different implementations, |
So the issue remains open, have no more ideas for now. |
I looked deeper into the copy/pasting not working while composing issue and seem to found out why it didn't work. It's because message editing is happening inside a dynamically created iframe element. So now I'm processing the dynamically created iframes too and so hopefully all the cases will be properly handled with a new version uploaded here. Can someone try it? I promise there will be no more new builds for today 😊 |
Uh oh!
There was an error while loading. Please reload this page.
.
The text was updated successfully, but these errors were encountered: