feat(error): impproved error messages for missing members

Author: vknabel

CHANGELOG.md

@@ -5,6 +5,7 @@
 - fix(lsp): `lithia lsp tcp` didn't work as expected
 - fix(cli): correctly handle running script and repl
 - feat(stdlib): `os.args` returns the arguments passed to the program
+- feat(error): impproved error messages for missing members
 
 ## v0.0.18
 

runtime/prelude-anonymous-function.go

@@ -33,7 +33,7 @@ func (f PreludeAnonymousFunction) Lookup(member string) (Evaluatable, *RuntimeEr
 	case "arity":
 		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, f.RuntimeType().String())
 	}
 }
 

runtime/prelude-curried-callable.go

@@ -28,7 +28,7 @@ func (f PreludeCurriedCallable) Lookup(member string) (Evaluatable, *RuntimeErro
 	case "arity":
 		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, f.RuntimeType().String())
 	}
 }
 

runtime/prelude-dict.go

@@ -149,7 +149,7 @@ func (rv PreludeDict) Lookup(member string) (Evaluatable, *RuntimeError) {
 		dataList, err := rv.context.environment.MakeList(values)
 		return NewConstantRuntimeValue(dataList), err
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, rv.RuntimeType().String())
 	}
 }
 

runtime/prelude-extern-function.go

@@ -34,7 +34,7 @@ func (f PreludeExternFunction) Lookup(member string) (Evaluatable, *RuntimeError
 	case "arity":
 		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, f.RuntimeType().String())
 	}
 }
 

runtime/prelude-extern-type-method.go

@@ -37,7 +37,7 @@ func (f PreludeExternTypeMethod) Lookup(member string) (Evaluatable, *RuntimeErr
 	case "arity":
 		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, f.RuntimeType().String())
 	}
 }
 

runtime/prelude-func-decl.go

@@ -48,7 +48,7 @@ func (f PreludeFuncDecl) Lookup(member string) (Evaluatable, *RuntimeError) {
 	case "arity":
 		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, f.RuntimeType().String())
 	}
 }
 

runtime/prelude-func-expr.go

@@ -43,7 +43,7 @@ func (f PreludeFuncExpr) Lookup(member string) (Evaluatable, *RuntimeError) {
 	case "arity":
 		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, f.RuntimeType().String())
 	}
 }
 

runtime/prelude-string.go

@@ -17,10 +17,10 @@ func (s PreludeString) EagerEvaluate() *RuntimeError {
 	return nil
 }
 
-func (i PreludeString) Lookup(member string) (Evaluatable, *RuntimeError) {
+func (s PreludeString) Lookup(member string) (Evaluatable, *RuntimeError) {
 	switch member {
 	case "length":
-		return NewConstantRuntimeValue(PreludeInt(len(i))), nil
+		return NewConstantRuntimeValue(PreludeInt(len(s))), nil
 	case "append":
 		return NewConstantRuntimeValue(MakeAnonymousFunction(
 			"append",
@@ -30,9 +30,9 @@ func (i PreludeString) Lookup(member string) (Evaluatable, *RuntimeError) {
 				if err != nil {
 					return nil, err
 				}
-				return PreludeString(i) + PreludeString(value.String()), nil
+				return PreludeString(s) + PreludeString(value.String()), nil
 			})), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, s.RuntimeType().String())
 	}
 }

runtime/prelude-type-switch-expr.go

@@ -27,12 +27,12 @@ func MakePreludeTypeSwitchExpr(context *InterpreterContext, decl ast.ExprTypeSwi
 	return PreludeTypeSwitchExpr{decl, context, MakeEvaluatableExpr(context, decl.Type), caseValue}
 }
 
-func (f PreludeTypeSwitchExpr) Lookup(member string) (Evaluatable, *RuntimeError) {
+func (t PreludeTypeSwitchExpr) Lookup(member string) (Evaluatable, *RuntimeError) {
 	switch member {
 	case "arity":
-		return NewConstantRuntimeValue(PreludeInt(f.Arity())), nil
+		return NewConstantRuntimeValue(PreludeInt(t.Arity())), nil
 	default:
-		return nil, NewRuntimeErrorf("no such member: %s", member)
+		return nil, NewRuntimeErrorf("no such member: %s for %s", member, t.RuntimeType().String())
 	}
 }
 

world/osworld.go

@@ -9,5 +9,6 @@ func New() World {
 		Stderr: os.Stderr,
 		FS:     OSFS{},
 		Env:    OSEnv{},
+		Args:   os.Args,
 	}
 }

world/world.go

@@ -10,8 +10,9 @@ type World struct {
 	Stdout io.Writer
 	Stderr io.Writer
 
-	FS  WorldFS
-	Env WorldEnv
+	FS   WorldFS
+	Env  WorldEnv
+	Args []string
 }
 
 type WorldFS interface {