Skip to content

Commit c246801

Browse files
Filter port invalid MTU configuration (sonic-net#2378)
What I did Filter port invalid MTU configuration Adjust the MTU value to the range of [68,9216]
1 parent 362ec9b commit c246801

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

config/main.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4212,7 +4212,7 @@ def _get_all_mgmtinterface_keys():
42124212
@interface.command()
42134213
@click.pass_context
42144214
@click.argument('interface_name', metavar='<interface_name>', required=True)
4215-
@click.argument('interface_mtu', metavar='<interface_mtu>', required=True)
4215+
@click.argument('interface_mtu', metavar='<interface_mtu>', required=True, type=click.IntRange(68, 9216))
42164216
@click.option('-v', '--verbose', is_flag=True, help="Enable verbose output")
42174217
def mtu(ctx, interface_name, interface_mtu, verbose):
42184218
"""Set interface mtu"""

tests/config_int_mtu_test.py

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
import pytest
2+
import config.main as config
3+
from click.testing import CliRunner
4+
from utilities_common.db import Db
5+
6+
class TestConfigInterfaceMtu(object):
7+
def test_interface_mtu_check(self):
8+
runner = CliRunner()
9+
db = Db()
10+
result = runner.invoke(config.config.commands["interface"].commands["mtu"],
11+
["Ethernet0", "68"], obj=db)
12+
assert result.exit_code != 0
13+
14+
result1 = runner.invoke(config.config.commands["interface"].commands["mtu"],
15+
["Ethernet0", "9216"], obj=db)
16+
assert result1.exit_code != 0
17+
18+
def test_interface_invalid_mtu_check(self):
19+
runner = CliRunner()
20+
db = Db()
21+
result = runner.invoke(config.config.commands["interface"].commands["mtu"],
22+
["Ethernet0", "67"], obj=db)
23+
assert "Error: Invalid value" in result.output
24+
result1 = runner.invoke(config.config.commands["interface"].commands["mtu"],
25+
["Ethernet0", "9217"], obj=db)
26+
assert "Error: Invalid value" in result1.output

0 commit comments

Comments
 (0)