Skip to content

Commit 0573416

Browse files
authored
Remove the argument that is causing the xcvrd to crash (sonic-net#318)
- Description Fixed SfpStateUpdateTask to not crash during port_cfg dynamic add/del event - Motivation and Context During port breakout, the subprocess invoked by parent xcvrd is crashing indicated in the log - How Has This Been Tested? Apply breakout and check if the subprocess is not crashing Signed-off-by: Vivek Reddy <[email protected]>
1 parent e474335 commit 0573416

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

sonic-xcvrd/xcvrd/xcvrd.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
try:
99
import ast
1010
import copy
11-
import functools
1211
import json
1312
import multiprocessing
1413
import os
@@ -1794,9 +1793,8 @@ def task_worker(self, stopping_event, sfp_error_event):
17941793
timeout = RETRY_PERIOD_FOR_SYSTEM_READY_MSECS
17951794
state = STATE_INIT
17961795
sel, asic_context = port_mapping.subscribe_port_config_change(self.namespaces)
1797-
port_change_event_handler = functools.partial(self.on_port_config_change, stopping_event)
17981796
while not stopping_event.is_set():
1799-
port_mapping.handle_port_config_change(sel, asic_context, stopping_event, self.port_mapping, helper_logger, port_change_event_handler)
1797+
port_mapping.handle_port_config_change(sel, asic_context, stopping_event, self.port_mapping, helper_logger, self.on_port_config_change)
18001798

18011799
# Retry those logical ports whose EEPROM reading failed or timeout when the SFP is inserted
18021800
self.retry_eeprom_reading()

0 commit comments

Comments
 (0)