-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Hidden node_modules dependencies in Module Graph #5363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
All inlined dependencies are represented in a module graph. Why shouldn't these be displayed? How would you know they are inlined? |
I've debugged it, and it appears that the color for "external" should be yellow, not green. I tested the dependencies of math.js and found that it has at least 500 dependencies. If all of them were shown, the browser would become very laggy. However, usually we don't need to know about these dependencies. |
It is not "external", it is inlined. This module was processed with vite-node, and not imported with a dynamic |
Graph view being laggy was reported in #4762. I just tested with react-testing-lib example https://github.com/vitest-dev/vitest/tree/main/examples and it doesn't look really usable when there are many files from So maybe it makes sense to have yet another toggle for "inline modules" inside and outside of |
I think we can have a "Hide node_modules" toggle to address the issue with performance. |
Clear and concise description of the problem
I found some dependencies(math.js etc.) will display in Module Graph, and it was regarded as inline modules。
Suggested solution
Hidden those dependencies in Module Graph
Alternative
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: