fix(snapshot): fix toMatchFileSnapshot with empty file (#5894)

hi-ogawa · web-flow · commit 8800601d2e31 · 2024-06-16T09:20:51.000+03:00
diff --git a/packages/snapshot/src/client.ts b/packages/snapshot/src/client.ts
@@ -159,7 +159,7 @@ export class SnapshotClient {
       options.filepath ||= filepath
       // resolve and read the raw snapshot file
       rawSnapshot.file = await snapshotState.environment.resolveRawPath(filepath, rawSnapshot.file)
-      rawSnapshot.content = await snapshotState.environment.readSnapshotFile(rawSnapshot.file) || undefined
+      rawSnapshot.content = await snapshotState.environment.readSnapshotFile(rawSnapshot.file) ?? undefined
     }
 
     return this.assert(options)
diff --git a/test/core/test/fixtures/snapshot-empty.txt b/test/core/test/fixtures/snapshot-empty.txt
diff --git a/test/core/test/snapshot-file.test.ts b/test/core/test/snapshot-file.test.ts
@@ -18,3 +18,7 @@ describe('snapshots', () => {
     })
   }
 })
+
+test('handle empty file', () => {
+  expect('').toMatchFileSnapshot('./fixtures/snapshot-empty.txt')
+})

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ export class SnapshotClient {`
`159`	`159`	`options.filepath \|\|= filepath`
`160`	`160`	`// resolve and read the raw snapshot file`
`161`	`161`	`rawSnapshot.file = await snapshotState.environment.resolveRawPath(filepath, rawSnapshot.file)`
`162`		`- rawSnapshot.content = await snapshotState.environment.readSnapshotFile(rawSnapshot.file) \|\| undefined`
	`162`	`+ rawSnapshot.content = await snapshotState.environment.readSnapshotFile(rawSnapshot.file) ?? undefined`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`return this.assert(options)`
Original file line number	Diff line number	Diff line change
`@@ -18,3 +18,7 @@ describe('snapshots', () => {`
`18`	`18`	`})`
`19`	`19`	`}`
`20`	`20`	`})`
	`21`	`+`
	`22`	`+test('handle empty file', () => {`
	`23`	`+ expect('').toMatchFileSnapshot('./fixtures/snapshot-empty.txt')`
	`24`	`+})`