Skip to content

worker.rollupOptions is ignored if set in a plugin #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
Rich-Harris opened this issue Jul 18, 2022 · 0 comments · Fixed by #9212
Closed
7 tasks done

worker.rollupOptions is ignored if set in a plugin #9205

Rich-Harris opened this issue Jul 18, 2022 · 0 comments · Fixed by #9212
Labels
feat: web workers p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Comments

@Rich-Harris
Copy link
Contributor

Describe the bug

If I set worker.rollupOptions in my vite.config.js I can control where workers are written to, but if it's set by a plugin, the configuration is discarded. This makes it hard for frameworks like SvelteKit to write them to a suitable location.

Reproduction

https://github.com/Rich-Harris/vite-workers-repro

System Info

System:
    OS: macOS 12.0.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 198.39 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.15.1/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Chrome Canary: 105.0.5187.0
    Firefox: 102.0.1
    Safari: 15.1
  npmPackages:
    vite: ^3.0.2 => 3.0.2

Used Package Manager

npm

Logs

No response

Validations

@sapphi-red sapphi-red added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Jul 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: web workers p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants