chore: node prefix lint (#9514)

Author: sapphi-red

.eslintrc.cjs

@@ -1,4 +1,5 @@
 // @ts-check
+const { builtinModules } = require('node:module')
 const { defineConfig } = require('eslint-define-config')
 
 module.exports = defineConfig({
@@ -81,6 +82,10 @@ module.exports = defineConfig({
       { prefer: 'type-imports' }
     ],
 
+    'import/no-nodejs-modules': [
+      'error',
+      { allow: builtinModules.map((mod) => `node:${mod}`) }
+    ],
     'import/no-duplicates': 'error',
     'import/order': 'error',
     'sort-imports': [

packages/vite/bin/vite.js

@@ -50,7 +50,7 @@ if (profileIndex > 0) {
   if (next && !next.startsWith('-')) {
     process.argv.splice(profileIndex, 1)
   }
-  const inspector = await import('inspector').then((r) => r.default)
+  const inspector = await import('node:inspector').then((r) => r.default)
   const session = (global.__vite_profile_session = new inspector.Session())
   session.connect()
   session.post('Profiler.enable', () => {

packages/vite/src/node/http.ts

@@ -95,16 +95,16 @@ export async function resolveHttpServer(
   httpsOptions?: HttpsServerOptions
 ): Promise<HttpServer> {
   if (!httpsOptions) {
-    const { createServer } = await import('http')
+    const { createServer } = await import('node:http')
     return createServer(app)
   }
 
   // #484 fallback to http1 when proxy is needed.
   if (proxy) {
-    const { createServer } = await import('https')
+    const { createServer } = await import('node:https')
     return createServer(httpsOptions, app)
   } else {
-    const { createSecureServer } = await import('http2')
+    const { createSecureServer } = await import('node:http2')
     return createSecureServer(
       {
         // Manually increase the session memory to prevent 502 ENHANCE_YOUR_CALM

packages/vite/src/node/logger.ts

@@ -1,6 +1,6 @@
 /* eslint no-console: 0 */
 
-import readline from 'readline'
+import readline from 'node:readline'
 import colors from 'picocolors'
 import type { RollupError } from 'rollup'
 import type { ResolvedServerUrls } from './server'

packages/vite/src/node/plugins/ssrRequireHook.ts

@@ -53,7 +53,9 @@ type NodeResolveFilename = (
 /** Respect the `resolve.dedupe` option in production SSR. */
 function dedupeRequire(dedupe: string[]) {
   // eslint-disable-next-line no-restricted-globals
-  const Module = require('module') as { _resolveFilename: NodeResolveFilename }
+  const Module = require('node:module') as {
+    _resolveFilename: NodeResolveFilename
+  }
   const resolveFilename = Module._resolveFilename
   Module._resolveFilename = function (request, parent, isMain, options) {
     if (request[0] !== '.' && request[0] !== '/') {

packages/vite/types/ws.d.ts

@@ -26,7 +26,7 @@ import type {
 } from 'node:http'
 import type { Server as HTTPSServer } from 'node:https'
 import type { Duplex, DuplexOptions } from 'node:stream'
-import type { SecureContextOptions } from 'tls'
+import type { SecureContextOptions } from 'node:tls'
 import type { URL } from 'node:url'
 import type { ZlibOptions } from 'node:zlib'
 

playground/alias/vite.config.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/assets/vite.config-runtime-base.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 const dynamicBaseAssetsCode = `
 globalThis.__toAssetUrl = url => '/' + url

playground/assets/vite.config.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/backend-integration/vite.config.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 const glob = require('fast-glob')
 const normalizePath = require('vite').normalizePath
 

playground/css-codesplit-cjs/vite.config.js

@@ -1,4 +1,4 @@
-const { resolve } = require('path')
+const { resolve } = require('node:path')
 
 module.exports = {
   build: {

playground/css-codesplit/vite.config.js

@@ -1,4 +1,4 @@
-const { resolve } = require('path')
+const { resolve } = require('node:path')
 
 module.exports = {
   build: {

playground/css/postcss.config.js

@@ -2,8 +2,8 @@ module.exports = {
   plugins: [require('postcss-nested'), testDirDep, testSourceInput]
 }
 
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const glob = require('fast-glob')
 const { normalizePath } = require('vite')
 

playground/css/vite.config.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/dynamic-import/vite.config.js

@@ -1,5 +1,5 @@
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const vite = require('vite')
 
 module.exports = vite.defineConfig({

playground/fs-serve/root/vite.config.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/html/vite.config.js

@@ -1,4 +1,4 @@
-const { resolve } = require('path')
+const { resolve } = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/json/server.js

@@ -1,6 +1,6 @@
 // @ts-check
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const express = require('express')
 
 const isTest = process.env.NODE_ENV === 'test' || !!process.env.VITE_TEST_BUILD

playground/legacy/vite.config.js

@@ -1,5 +1,5 @@
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const legacy = require('@vitejs/plugin-legacy').default
 
 module.exports = {

playground/lib/vite.config.js

@@ -1,5 +1,5 @@
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/lib/vite.dyimport.config.js

@@ -1,5 +1,5 @@
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 
 /**
  * @type {import('vite').UserConfig}

playground/multiple-entrypoints/vite.config.js

@@ -1,5 +1,5 @@
-const { resolve } = require('path')
-const fs = require('fs')
+const { resolve } = require('node:path')
+const fs = require('node:fs')
 
 module.exports = {
   build: {

playground/optimize-deps/dep-with-builtin-module-cjs/index.js

@@ -1,5 +1,7 @@
 // no node: protocol intentionally
+// eslint-disable-next-line import/no-nodejs-modules
 const fs = require('fs')
+// eslint-disable-next-line import/no-nodejs-modules
 const path = require('path')
 
 // NOTE: require destructure would error immediately because of how esbuild

playground/optimize-deps/dep-with-builtin-module-esm/index.js

@@ -1,5 +1,7 @@
 // no node: protocol intentionally
+// eslint-disable-next-line import/no-nodejs-modules
 import { readFileSync } from 'fs'
+// eslint-disable-next-line import/no-nodejs-modules
 import path from 'path'
 
 // access from named import

playground/optimize-deps/vite.config.js

@@ -1,4 +1,4 @@
-const fs = require('fs')
+const fs = require('node:fs')
 const vue = require('@vitejs/plugin-vue')
 
 // Overriding the NODE_ENV set by vitest

playground/optimize-missing-deps/multi-entry-dep/index.js

@@ -1,3 +1,3 @@
-const path = require('path')
+const path = require('node:path')
 
 exports.name = path.normalize('./Server')

playground/optimize-missing-deps/server.js

@@ -1,6 +1,6 @@
 // @ts-check
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const express = require('express')
 
 const isTest = process.env.NODE_ENV === 'test' || !!process.env.VITE_TEST_BUILD

playground/resolve/browser-field/multiple.dot.path.js

@@ -1,2 +1,2 @@
-const fs = require('fs')
+const fs = require('node:fs')
 console.log('this should not run in the browser')

playground/resolve/browser-field/not-browser.js

@@ -1,2 +1,2 @@
-const fs = require('fs')
+const fs = require('node:fs')
 console.log('this should not run in the browser')

playground/ssr-deps/import-builtin-cjs/index.js

@@ -1,4 +1,4 @@
-exports.stream = require('stream')
+exports.stream = require('node:stream')
 
 exports.hello = function () {
   return 'Hello World!'

playground/ssr-deps/read-file-content/index.js

@@ -1,9 +1,9 @@
-const path = require('path')
+const path = require('node:path')
 
 module.exports = async function readFileContent(filePath) {
   const fs =
     process.versions.node.split('.')[0] >= '14'
-      ? require('fs/promises')
-      : require('fs').promises
+      ? require('node:fs/promises')
+      : require('node:fs').promises
   return await fs.readFile(path.resolve(filePath), 'utf-8')
 }

playground/ssr-deps/require-absolute/index.js

@@ -1,3 +1,3 @@
-const path = require('path')
+const path = require('node:path')
 
 module.exports.hello = () => require(path.resolve(__dirname, './foo.js')).hello

playground/ssr-deps/server.js

@@ -1,7 +1,7 @@
 // @ts-check
 import fs from 'node:fs'
 import path from 'node:path'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import express from 'express'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))

playground/ssr-html/server.js

@@ -1,6 +1,6 @@
 import fs from 'node:fs'
 import path from 'node:path'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import express from 'express'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))

playground/ssr-pug/server.js

@@ -1,6 +1,6 @@
 // @ts-check
 import path from 'node:path'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import pug from 'pug'
 import express from 'express'
 

playground/ssr-react/prerender.js

@@ -3,7 +3,7 @@
 
 import fs from 'node:fs'
 import path from 'node:path'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const toAbsolute = (p) => path.resolve(__dirname, p)

playground/ssr-react/server.js

@@ -1,6 +1,6 @@
 import fs from 'node:fs'
 import path from 'node:path'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import express from 'express'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))

playground/ssr-vue/server.js

@@ -1,7 +1,7 @@
 // @ts-check
 import fs from 'node:fs'
 import path from 'node:path'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import express from 'express'
 
 const isTest = process.env.NODE_ENV === 'test' || !!process.env.VITE_TEST_BUILD

playground/ssr-vue/vite.config.js

@@ -1,4 +1,4 @@
-import path from 'path'
+import path from 'node:path'
 import { defineConfig } from 'vite'
 import vuePlugin from '@vitejs/plugin-vue'
 import vueJsx from '@vitejs/plugin-vue-jsx'

playground/ssr-webworker/worker.js

@@ -1,4 +1,4 @@
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import path from 'node:path'
 import { Miniflare } from 'miniflare'
 

playground/worker/vite.config-relative-base.js

@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 const vueJsx = require('@vitejs/plugin-vue-jsx')
 const vite = require('vite')