fix: fixed dts only out generation, fixed compatibility mode if the value is true

Author: prisis

packages/packem/__tests__/intigration/__snapshots__/typescript.test.ts.snap

@@ -440,6 +440,119 @@ export type { NativeStringTypes };
 "
 `;
 
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts > .d.ts type code output 1`] = `
+"declare global {
+    interface String {
+
+    }
+}
+
+type NativeStringTypes = string;
+
+export type { NativeStringTypes };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > .d.cts type code output 1`] = `
+"declare global {
+    interface String {
+
+    }
+}
+
+type NativeStringTypes = string;
+
+export type { NativeStringTypes };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > .d.mts type code output 1`] = `
+"declare global {
+    interface String {
+
+    }
+}
+
+type NativeStringTypes = string;
+
+export type { NativeStringTypes };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > .d.ts type code output 1`] = `
+"declare global {
+    interface String {
+
+    }
+}
+
+type NativeStringTypes = string;
+
+export type { NativeStringTypes };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > cjs content 1`] = `
+"'use strict';
+
+Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
+const isUpperCode = new Uint8Array(128);
+const isLowerCode = new Uint8Array(128);
+const isDigitCode = new Uint8Array(128);
+for (let index = 0; index < 128; index++) {
+  isUpperCode[index] = index >= 65 && index <= 90 ? 1 : 0;
+  isLowerCode[index] = index >= 97 && index <= 122 ? 1 : 0;
+  isDigitCode[index] = index >= 48 && index <= 57 ? 1 : 0;
+}
+
+exports.isDigitCode = isDigitCode;
+exports.isLowerCode = isLowerCode;
+exports.isUpperCode = isUpperCode;
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > d.cts content 1`] = `
+"declare const isUpperCode: Uint8Array<ArrayBuffer>;
+declare const isLowerCode: Uint8Array<ArrayBuffer>;
+declare const isDigitCode: Uint8Array<ArrayBuffer>;
+
+export { isDigitCode, isLowerCode, isUpperCode };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > d.mts content 1`] = `
+"declare const isUpperCode: Uint8Array<ArrayBuffer>;
+declare const isLowerCode: Uint8Array<ArrayBuffer>;
+declare const isDigitCode: Uint8Array<ArrayBuffer>;
+
+export { isDigitCode, isLowerCode, isUpperCode };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > d.ts content 1`] = `
+"declare const isUpperCode: Uint8Array<ArrayBuffer>;
+declare const isLowerCode: Uint8Array<ArrayBuffer>;
+declare const isDigitCode: Uint8Array<ArrayBuffer>;
+
+export { isDigitCode, isLowerCode, isUpperCode };
+"
+`;
+
+exports[`packem typescript > should compile a .d.ts file into .d.cts and .d.mts, with other exports > mjs content 1`] = `
+"const isUpperCode = new Uint8Array(128);
+const isLowerCode = new Uint8Array(128);
+const isDigitCode = new Uint8Array(128);
+for (let index = 0; index < 128; index++) {
+  isUpperCode[index] = index >= 65 && index <= 90 ? 1 : 0;
+  isLowerCode[index] = index >= 97 && index <= 122 ? 1 : 0;
+  isDigitCode[index] = index >= 48 && index <= 57 ? 1 : 0;
+}
+
+export { isDigitCode, isLowerCode, isUpperCode };
+"
+`;
+
 exports[`packem typescript > should compile only a type file > .d.ts type code output 1`] = `
 "declare global {
     interface String {

packages/packem/__tests__/intigration/typescript.test.ts

@@ -2953,7 +2953,7 @@ declare global {
     });
 
     it("should compile a .d.ts file into .d.cts and .d.mts", async () => {
-        expect.assertions(4);
+        expect.assertions(5);
 
         await writeFile(`${temporaryDirectoryPath}/src/native-string-types.d.ts`, `
 declare global {
@@ -2987,7 +2987,83 @@ export type NativeStringTypes = string;
         const binProcess = await execPackemSync("build", [], {
             cwd: temporaryDirectoryPath,
         });
-console.log(binProcess.stdout);
+
+        expect(binProcess.stderr).toBe("");
+        expect(binProcess.exitCode).toBe(0);
+
+        const dCtsContent = await readFile(`${temporaryDirectoryPath}/dist/native-string-types.d.cts`);
+
+        expect(dCtsContent).toMatchSnapshot(".d.cts type code output");
+
+        const dMtsContent = await readFile(`${temporaryDirectoryPath}/dist/native-string-types.d.mts`);
+
+        expect(dMtsContent).toMatchSnapshot(".d.mts type code output");
+
+        const dTsContent = await readFile(`${temporaryDirectoryPath}/dist/native-string-types.d.ts`);
+
+        expect(dTsContent).toMatchSnapshot(".d.ts type code output");
+    });
+
+    it("should compile a .d.ts file into .d.cts and .d.mts, with other exports", async () => {
+        expect.assertions(10);
+
+        await writeFile(`${temporaryDirectoryPath}/src/native-string-types.d.ts`, `
+declare global {
+    interface String {
+
+    }
+}
+
+export type NativeStringTypes = string;
+`);
+        await writeFile(`${temporaryDirectoryPath}/src/index.ts`, `// Fast lookup tables for performance optimization
+const isUpperCode = new Uint8Array(128);
+const isLowerCode = new Uint8Array(128);
+const isDigitCode = new Uint8Array(128);
+
+// Initialize lookup tables once
+for (let index = 0; index < 128; index++) {
+    isUpperCode[index] = index >= 65 && index <= 90 ? 1 : 0; // A-Z
+    isLowerCode[index] = index >= 97 && index <= 122 ? 1 : 0; // a-z
+    isDigitCode[index] = index >= 48 && index <= 57 ? 1 : 0; // 0-9
+}
+
+export { isUpperCode, isLowerCode, isDigitCode };
+`);
+
+        await installPackage(temporaryDirectoryPath, "typescript");
+        await createTsConfig(temporaryDirectoryPath);
+        await createPackageJson(temporaryDirectoryPath, {
+            devDependencies: {
+                typescript: "*",
+            },
+            exports: {
+                "./index": {
+                    import: {
+                        default: "./index.mjs",
+                        types: "./index.d.mts",
+                    },
+                    require: {
+                        default: "./index.cjs",
+                        types: "./index.d.cts",
+                    },
+                },
+                "./native-string-types": {
+                    import: {
+                        types: "./native-string-types.d.mts",
+                    },
+                    require: {
+                        types: "./native-string-types.d.cts",
+                    },
+                }
+            },
+        });
+        await createPackemConfig(temporaryDirectoryPath);
+
+        const binProcess = await execPackemSync("build", [], {
+            cwd: temporaryDirectoryPath,
+        });
+
         expect(binProcess.stderr).toBe("");
         expect(binProcess.exitCode).toBe(0);
 
@@ -2998,5 +3074,29 @@ console.log(binProcess.stdout);
         const dMtsContent = await readFile(`${temporaryDirectoryPath}/dist/native-string-types.d.mts`);
 
         expect(dMtsContent).toMatchSnapshot(".d.mts type code output");
+
+        const dTsContent = await readFile(`${temporaryDirectoryPath}/dist/native-string-types.d.ts`);
+
+        expect(dTsContent).toMatchSnapshot(".d.ts type code output");
+
+        const cjsIndexContent = await readFile(`${temporaryDirectoryPath}/dist/index.cjs`);
+
+        expect(cjsIndexContent).toMatchSnapshot("cjs content");
+
+        const mjsIndexContent = await readFile(`${temporaryDirectoryPath}/dist/index.mjs`);
+
+        expect(mjsIndexContent).toMatchSnapshot("mjs content");
+
+        const dTsIndexContent = await readFile(`${temporaryDirectoryPath}/dist/index.d.ts`);
+
+        expect(dTsIndexContent).toMatchSnapshot("d.ts content");
+
+        const dCtsIndexContent = await readFile(`${temporaryDirectoryPath}/dist/index.d.cts`);
+
+        expect(dCtsIndexContent).toMatchSnapshot("d.cts content");
+
+        const dMtsIndexContent = await readFile(`${temporaryDirectoryPath}/dist/index.d.mts`);
+
+        expect(dMtsIndexContent).toMatchSnapshot("d.mts content");
     });
 });

packages/packem/src/packem/build.ts

@@ -248,6 +248,8 @@ interface BuilderProperties {
     subDirectory: string;
 }
 
+const DTS_REGEX = /\.d\.[mc]?ts$/;
+
 /**
  * Prepares Rollup configuration for both JavaScript/TypeScript builds and type definition builds.
  * Processes entries and generates appropriate builder configurations.
@@ -330,12 +332,9 @@ const prepareRollupConfig = (
             const esmEntries: BuildEntry[] = [];
             const cjsEntries: BuildEntry[] = [];
             const dtsEntries: BuildEntry[] = [];
-            const dtsOnlyEntries: BuildEntry[] = [];
 
             for (const entry of entries) {
-                if (/\.d\.[cm]?ts$/.test(entry.input)) {
-                    dtsOnlyEntries.push(entry);
-                } else if (entry.cjs && entry.esm) {
+                if (entry.cjs && entry.esm) {
                     esmAndCjsEntries.push(entry);
                 } else if (entry.cjs) {
                     cjsEntries.push(entry);
@@ -353,7 +352,7 @@ const prepareRollupConfig = (
                         ...environmentRuntimeContext.options,
                         emitCJS: true,
                         emitESM: true,
-                        entries: esmAndCjsEntries,
+                        entries: [...esmAndCjsEntries].filter((entry) => !DTS_REGEX.test(entry.input)),
                         minify,
                         rollup: {
                             ...environmentRuntimeContext.options.rollup,
@@ -375,7 +374,7 @@ const prepareRollupConfig = (
                 }
 
                 if (context.options.declaration) {
-                    const typedEntries = adjustedEsmAndCjsContext.options.entries.filter((entry) => entry.declaration);
+                    const typedEntries = [...esmAndCjsEntries].filter((entry) => entry.declaration);
 
                     if (typedEntries.length > 0) {
                         typeBuilders.add({
@@ -400,7 +399,7 @@ const prepareRollupConfig = (
                         ...environmentRuntimeContext.options,
                         emitCJS: false,
                         emitESM: true,
-                        entries: esmEntries,
+                        entries: [...esmEntries].filter((entry) => !DTS_REGEX.test(entry.input)),
                         minify,
                         rollup: {
                             ...environmentRuntimeContext.options.rollup,
@@ -422,7 +421,7 @@ const prepareRollupConfig = (
                 }
 
                 if (context.options.declaration) {
-                    const typedEntries = adjustedEsmContext.options.entries.filter((entry) => entry.declaration);
+                    const typedEntries = [...esmEntries].filter((entry) => entry.declaration);
 
                     if (typedEntries.length > 0) {
                         typeBuilders.add({
@@ -447,7 +446,7 @@ const prepareRollupConfig = (
                         ...environmentRuntimeContext.options,
                         emitCJS: true,
                         emitESM: false,
-                        entries: cjsEntries,
+                        entries: [...cjsEntries].filter((entry) => !DTS_REGEX.test(entry.input)),
                         minify,
                         rollup: {
                             ...environmentRuntimeContext.options.rollup,
@@ -469,7 +468,7 @@ const prepareRollupConfig = (
                 }
 
                 if (context.options.declaration) {
-                    const typedEntries = adjustedCjsContext.options.entries.filter((entry) => entry.declaration);
+                    const typedEntries = [...cjsEntries].filter((entry) => entry.declaration);
 
                     if (typedEntries.length > 0) {
                         typeBuilders.add({
@@ -515,33 +514,6 @@ const prepareRollupConfig = (
                     subDirectory,
                 });
             }
-
-            if (environmentRuntimeContext.options.declaration && dtsOnlyEntries.length > 0) {
-                typeBuilders.add({
-                    context: {
-                        ...environmentRuntimeContext,
-                        options: {
-                            ...environmentRuntimeContext.options,
-                            entries: dtsOnlyEntries,
-                            minify,
-                            rollup: {
-                                ...environmentRuntimeContext.options.rollup,
-                                replace: environmentRuntimeContext.options.rollup.replace
-                                    ? {
-                                          ...environmentRuntimeContext.options.rollup.replace,
-                                          values: {
-                                              ...environmentRuntimeContext.options.rollup.replace.values,
-                                              ...replaceValues,
-                                          },
-                                      }
-                                    : false,
-                            },
-                        },
-                    },
-                    fileCache,
-                    subDirectory,
-                });
-            }
         }
     }
 

packages/packem/src/rollup/build-types.ts

@@ -58,7 +58,7 @@ const buildTypes = async (context: BuildContext, fileCache: FileCache, subDirect
     }
 
     // .d.ts for node10 compatibility (TypeScript version < 4.7)
-    if (context.options.declaration === "compatible") {
+    if (context.options.declaration === true || context.options.declaration === "compatible") {
         await typesBuild.write({
             chunkFileNames: (chunk) => getChunkFilename(chunk, "d.ts"),
             dir: resolve(context.options.rootDir, context.options.outDir),