Use typeof window.process !== 'undefined'

kribblo · web-flow · commit 408ae94373aa · 2016-12-20T21:33:50.000+01:00
'process' in window returns true after window.process = null
diff --git a/browser.js b/browser.js
@@ -40,7 +40,7 @@ function useColors() {
   // NB: In an Electron preload script, document will be defined but not fully
   // initialized. Since we know we're in Chrome, we'll just detect this case
   // explicitly
-  if (typeof window !== 'undefined' && 'process' in window && window.process.type === 'renderer') {
+  if (typeof window !== 'undefined' && typeof window.process !== 'undefined' && window.process.type === 'renderer') {
     return true;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ function useColors() {`
`40`	`40`	`// NB: In an Electron preload script, document will be defined but not fully`
`41`	`41`	`// initialized. Since we know we're in Chrome, we'll just detect this case`
`42`	`42`	`// explicitly`
`43`		`- if (typeof window !== 'undefined' && 'process' in window && window.process.type === 'renderer') {`
	`43`	`+ if (typeof window !== 'undefined' && typeof window.process !== 'undefined' && window.process.type === 'renderer') {`
`44`	`44`	`return true;`
`45`	`45`	`}`
`46`	`46`