Skip to content

Commit 2d0429d

Browse files
alvaroalemanvincepri
authored andcommitted
🏃 Disable golangs parallel testing
According to onsi/ginkgo#280 this doesn't seem to be properly supported. If we want parallelization, we should use ginkgos built-in mechanism for that.
1 parent fef0490 commit 2d0429d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

hack/test-all.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,16 @@ setup_envs
2222

2323
header_text "running go test"
2424

25-
# TODO(directxman12): enable the race detector once the LeaderElector race condition is resolved in client-go
26-
go test ${MOD_OPT} ./... -parallel 4
25+
go test -race ${MOD_OPT} ./...
2726

2827
header_text "running coverage"
2928

3029
# Verify no coverage regressions have been introduced. Remove the exception list from here
3130
# once the coverage has been brought back up
32-
if [[ ! $(go test ${MOD_OPT} ./pkg/... -coverprofile cover.out -parallel 4 | grep -v "coverage: 100.0% of statements" | grep "controller-runtime/pkg " | grep -v "controller-runtime/pkg \|controller-runtime/pkg/recorder \|pkg/cache\|pkg/client \|pkg/event \|pkg/client/config \|pkg/controller/controllertest \|pkg/reconcile/reconciletest \|pkg/test ") ]]; then
31+
if [[ ! $(go test ${MOD_OPT} ./pkg/... -coverprofile cover.out | grep -v "coverage: 100.0% of statements" | grep "controller-runtime/pkg " | grep -v "controller-runtime/pkg \|controller-runtime/pkg/recorder \|pkg/cache\|pkg/client \|pkg/event \|pkg/client/config \|pkg/controller/controllertest \|pkg/reconcile/reconciletest \|pkg/test ") ]]; then
3332
echo "ok"
3433
else
35-
go test ${MOD_OPT} ./pkg/... -coverprofile cover.out -parallel 4 | grep -v "coverage: 100.0% of statements" | grep "controller-runtime/pkg " | grep -v "controller-runtime/pkg \|controller-runtime/pkg/recorder \|pkg/cache\|pkg/client \|pkg/event \|pkg/client/config \|pkg/controller/controllertest \|pkg/reconcile/reconciletest \|pkg/test "
34+
go test ${MOD_OPT} ./pkg/... -coverprofile cover.out | grep -v "coverage: 100.0% of statements" | grep "controller-runtime/pkg " | grep -v "controller-runtime/pkg \|controller-runtime/pkg/recorder \|pkg/cache\|pkg/client \|pkg/event \|pkg/client/config \|pkg/controller/controllertest \|pkg/reconcile/reconciletest \|pkg/test "
3635
echo "missing test coverage"
3736
exit 1
3837
fi

0 commit comments

Comments
 (0)