Is that correct the effect dependencies are not exhaustive

[soulcm]

In the use-swr file, I found some effect dependencies not exhaustive, I want to konw it is correct or not.

If add eslint-plugin-react-hooks, and add "react-hooks/exhaustive-deps": "warn" in your .eslintrc It will warn that React Hook useEffect has missing dependencies: 'config. suspense'

the same as below code

const revalidate = useCallback(() => {
  // ... 
if (fnArgs !== null) {
            CONCURRENT_PROMISES[key] = fn(...fnArgs)
          } else {
            CONCURRENT_PROMISES[key] = fn(key)
          }
// ...
}, [key]) // the  fn args also not add the dependencies

anybody could make sense for me is that conrrect or not. thanks a lot

[koba04]

I've created a PR to fix this.

[koba04]

This has been fixed via #886, so we could close this.

[huozhi]

Close this as the warning has been disabled in latest commits. config.suspense is required to be static during the swr lifecycle.