add tests

Author: lobsterkatie

test/unit.test.js

@@ -4,7 +4,7 @@ const { nodeFileTrace } = require('../out/node-file-trace');
 
 global._unit = true;
 
-const skipOnWindows = ['yarn-workspaces', 'yarn-workspaces-base-root', 'yarn-workspace-esm', 'asset-symlink', 'require-symlink'];
+const skipOnWindows = ['yarn-workspaces', 'yarn-workspaces-base-root', 'yarn-workspace-esm', 'asset-symlink', 'require-symlink', "cjs-querystring"];
 const unitTestDirs = fs.readdirSync(join(__dirname, 'unit'));
 const unitTests = [
   ...unitTestDirs.map(testName => ({testName, isRoot: false})),
@@ -13,11 +13,26 @@ const unitTests = [
 
 for (const { testName, isRoot } of unitTests) {
   const testSuffix = `${testName} from ${isRoot ? 'root' : 'cwd'}`;
-  if (process.platform === 'win32' && (isRoot || skipOnWindows.includes(testName))) {
-    console.log(`Skipping unit test on Windows: ${testSuffix}`);
-    continue;
-  };
   const unitPath = join(__dirname, 'unit', testName);
+
+  if (process.platform === 'win32') { 
+    if (isRoot || skipOnWindows.includes(testName)) {
+      console.log(`Skipping unit test on Windows: ${testSuffix}`);
+      continue;
+    }
+  }
+  else {
+    // The point of this test is to see how filenames with question marks in
+    // them are handled, but that's disallowed in Windows, so much so that you
+    // can't even check out the commit for CI purposes if the `?`s are
+    // permanently in the filename. So we store the file without them and add
+    // them in just for the test on non-Windows platforms.
+    if (testName === 'cjs-querystring') {
+      const currentFilepath = join(unitPath, "whowhatidk.js") 
+      const newFilepath = currentFilepath.replace("whowhatidk.js", "who?what?idk!.js") 
+      fs.renameSync(currentFilepath, newFilepath)
+    }
+  }
 
   it(`should correctly trace ${testSuffix}`, async () => {
 
@@ -41,6 +56,25 @@ for (const { testName, isRoot } of unitTests) {
           return null
         }
       }
+
+      // mock an in-memory module store (such as webpack's) where the same filename with
+      // two different querystrings can correspond to two different modules, one importing
+      // the other
+      if (testName === "querystring-self-import") {
+        if (id.endsWith("input.js") || id.endsWith("base.js") || id.endsWith("dep.js")) {
+          return fs.readFileSync(id).toString()
+        }
+
+        if (id.endsWith("base.js?__withQuery")) {
+          return `
+            import * as origBase from './base';
+            export const dogs = origBase.dogs.concat('Cory', 'Bodhi');
+            export const cats = origBase.cats.concat('Teaberry', 'Sassafras', 'Persephone');
+            export const rats = origBase.rats;
+          `;
+        }
+      }
+
       return this.constructor.prototype.readFile.apply(this, arguments);
     });
 

test/unit/cjs-querystring/input.js

@@ -0,0 +1,7 @@
+// Test that CJS files treat question marks in filenames as any other character,
+// matching Node behavior
+
+// https://www.youtube.com/watch?v=2ve20PVNZ18
+
+const baseball = require("./who?what?idk!");
+console.log(baseball.players);

test/unit/cjs-querystring/output.js

@@ -0,0 +1,5 @@
+[
+  "package.json",
+  "test/unit/cjs-querystring/input.js",
+  "test/unit/cjs-querystring/who?what?idk!.js"
+]

test/unit/cjs-querystring/whowhatidk.js

@@ -0,0 +1,12 @@
+module.exports = {
+  players: {
+    first: "Who",
+    second: "What",
+    third: "I Don't Know",
+    left: "Why",
+    center: "Because",
+    pitcher: "Tomorrow",
+    catcher: "Today",
+    shortstop: "I Don't Give a Damn!",
+  },
+};

test/unit/esm-querystring/animalFacts/aardvark.js

@@ -0,0 +1,4 @@
+import { numSpecies } from "./bear?beaver?bison";
+console.log(`There are ${numSpecies} species of bears.`);
+
+export const food = "termites";

test/unit/esm-querystring/animalFacts/bear.js

@@ -0,0 +1,4 @@
+import * as cheetah from "./cheetah?cow=chipmunk";
+console.log(`Cheetahs can run ${cheetah.topSpeed} mph.`);
+
+export const numSpecies = 8;

test/unit/esm-querystring/animalFacts/cheetah.js

@@ -0,0 +1 @@
+export const topSpeed = 65;

test/unit/esm-querystring/input.js

@@ -0,0 +1,5 @@
+// Test that querystrings of various forms get stripped from esm imports
+
+import * as aardvark from "./animalFacts/aardvark?anteater";
+
+console.log(`Aardvarks eat ${aardvark.food}.`);

test/unit/esm-querystring/output.js

@@ -0,0 +1,7 @@
+[
+  "package.json",
+  "test/unit/esm-querystring/animalFacts/aardvark.js",
+  "test/unit/esm-querystring/animalFacts/bear.js",
+  "test/unit/esm-querystring/animalFacts/cheetah.js",
+  "test/unit/esm-querystring/input.js"
+]

test/unit/querystring-self-import/base.js

@@ -0,0 +1,5 @@
+import * as dep from "./dep";
+
+export const dogs = ["Charlie", "Maisey"];
+export const cats = ["Piper"];
+export const rats = dep.rats;

test/unit/querystring-self-import/dep.js

@@ -0,0 +1 @@
+export const rats = ["Debra"];

test/unit/querystring-self-import/input.js

@@ -0,0 +1,10 @@
+// Test that if a file and the same file with a querystring correspond to different
+// modules in memory, one can successfully import the other. The import chain
+// goes `input` (this file) -> `base?__withQuery` -> `base` -> `dep`, which means
+// that if `dep` shows up in `output`, we know that both `base?__withQuery` and
+// `base` have been loaded successfully.
+
+import * as baseWithQuery from "./base?__withQuery";
+console.log("Dogs:", baseWithQuery.dogs);
+console.log("Cats:", baseWithQuery.cats);
+console.log("Rats:", baseWithQuery.rats);

test/unit/querystring-self-import/output.js

@@ -0,0 +1,6 @@
+[
+  "package.json",
+  "test/unit/querystring-self-import/base.js",
+  "test/unit/querystring-self-import/dep.js",
+  "test/unit/querystring-self-import/input.js"
+]