fix: don't add isolateModules to tsconfig when extending from tsconfig with verbatimModuleSyntax (#54164)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

this is a follow-up to #48018 (don't add `isolatedModules: true` to
`tsconfig.json` when `verbatimModuleSyntax: true` is set), which also
handles the case where `verbatimModuleSyntax: true` is set in a base
tsconfig which is being referenced via `tsconfig#extends`.

---------

Co-authored-by: Zack Tanner <[email protected]>

Author: stefanprobst

packages/next/src/lib/typescript/writeConfigurationDefaults.ts

@@ -20,7 +20,7 @@ type DesiredCompilerOptionsShape = {
 
 function getDesiredCompilerOptions(
   ts: typeof import('typescript'),
-  userTsConfig?: { compilerOptions?: CompilerOptions }
+  tsOptions?: CompilerOptions
 ): DesiredCompilerOptionsShape {
   const o: DesiredCompilerOptionsShape = {
     // These are suggested values and will be set when not present in the
@@ -80,7 +80,7 @@ function getDesiredCompilerOptions(
       reason: 'to match webpack resolution',
     },
     resolveJsonModule: { value: true, reason: 'to match webpack resolution' },
-    ...(userTsConfig?.compilerOptions?.verbatimModuleSyntax === true
+    ...(tsOptions?.verbatimModuleSyntax === true
       ? undefined
       : {
           isolatedModules: {
@@ -139,7 +139,7 @@ export async function writeConfigurationDefaults(
     isFirstTimeSetup = true
   }
 
-  const desiredCompilerOptions = getDesiredCompilerOptions(ts, userTsConfig)
+  const desiredCompilerOptions = getDesiredCompilerOptions(ts, tsOptions)
 
   const suggestedActions: string[] = []
   const requiredActions: string[] = []

test/integration/tsconfig-verifier/test/index.test.js

@@ -567,6 +567,63 @@ import path from 'path'
     `)
     })
 
+    it('allows you to set verbatimModuleSyntax true via extends without adding isolatedModules', async () => {
+      expect(await exists(tsConfig)).toBe(false)
+      expect(await exists(tsConfigBase)).toBe(false)
+
+      await writeFile(
+        tsConfigBase,
+        `{ "compilerOptions": { "verbatimModuleSyntax": true } }`
+      )
+      await writeFile(tsConfig, `{ "extends": "./tsconfig.base.json" }`)
+      await new Promise((resolve) => setTimeout(resolve, 500))
+      const { code, stderr, stdout } = await nextBuild(appDir, undefined, {
+        stderr: true,
+        stdout: true,
+      })
+      expect(stderr + stdout).not.toContain('isolatedModules')
+      expect(code).toBe(0)
+
+      expect(await readFile(tsConfig, 'utf8')).toMatchInlineSnapshot(`
+        "{
+          \\"extends\\": \\"./tsconfig.base.json\\",
+          \\"compilerOptions\\": {
+            \\"lib\\": [
+              \\"dom\\",
+              \\"dom.iterable\\",
+              \\"esnext\\"
+            ],
+            \\"allowJs\\": true,
+            \\"skipLibCheck\\": true,
+            \\"strict\\": false,
+            \\"noEmit\\": true,
+            \\"incremental\\": true,
+            \\"esModuleInterop\\": true,
+            \\"module\\": \\"esnext\\",
+            \\"moduleResolution\\": \\"node\\",
+            \\"resolveJsonModule\\": true,
+            \\"jsx\\": \\"preserve\\",
+            \\"plugins\\": [
+              {
+                \\"name\\": \\"next\\"
+              }
+            ],
+            \\"strictNullChecks\\": true
+          },
+          \\"include\\": [
+            \\"next-env.d.ts\\",
+            \\".next/types/**/*.ts\\",
+            \\"**/*.ts\\",
+            \\"**/*.tsx\\"
+          ],
+          \\"exclude\\": [
+            \\"node_modules\\"
+          ]
+        }
+        "
+      `)
+    })
+
     it('allows you to extend another configuration file', async () => {
       expect(await exists(tsConfig)).toBe(false)
       expect(await exists(tsConfigBase)).toBe(false)