Skip to content

Commit 2a47931

Browse files
authored
Remove app dir warning test (#56350)
This test was failing in Turbopack because the option no longer exists. Fine to remove it for now. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
1 parent c95e4b7 commit 2a47931

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

test/integration/config-experimental-warning/test/index.test.js

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,6 @@ async function collectStdout(appDir) {
1919
return stdout
2020
}
2121

22-
async function collectStderr(appDir) {
23-
let stderr = ''
24-
const port = await findPort()
25-
app = await launchApp(appDir, port, {
26-
onStderr(msg) {
27-
stderr += msg
28-
},
29-
})
30-
return stderr
31-
}
32-
3322
describe('Config Experimental Warning', () => {
3423
afterEach(() => {
3524
configFile.write('')
@@ -123,19 +112,4 @@ describe('Config Experimental Warning', () => {
123112
expect(stdout).toMatch(' · workerThreads')
124113
expect(stdout).toMatch(' · scrollRestoration')
125114
})
126-
127-
it('should show warning for dropped experimental.appDir option', async () => {
128-
configFile.write(`
129-
module.exports = {
130-
experimental: {
131-
appDir: true,
132-
}
133-
}
134-
`)
135-
136-
const stderr = await collectStderr(appDir)
137-
expect(stderr).toMatch(
138-
'App router is available by default now, `experimental.appDir` option can be safely removed.'
139-
)
140-
})
141115
})

0 commit comments

Comments
 (0)