Skip to content

Commit 408b59e

Browse files
authored
chore(topology): Fix flaky topology_disk_buffer_conflict test (#15297)
When the scrape interval on the `internal_metrics` source is left at the default of 1.0 seconds or less, some kind of race condition in the `topology_disk_buffer_conflict` test is triggered, but it is unclear why. All these tests should work regardless of the scrape interval. This warrants further investigation, but this at least shuts up the flaky test.
1 parent 04aaf1a commit 408b59e

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/topology/test/reload.rs

+8-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,14 @@ use crate::{
2121
};
2222

2323
fn internal_metrics_source() -> InternalMetricsConfig {
24-
InternalMetricsConfig::default()
24+
InternalMetricsConfig {
25+
// TODO: A scrape interval left at the default of 1.0 seconds or less triggers some kind of
26+
// race condition in the `topology_disk_buffer_conflict` test below, but it is unclear
27+
// why. All these tests should work regardless of the scrape interval. This warrants further
28+
// investigation.
29+
scrape_interval_secs: 1.1,
30+
..Default::default()
31+
}
2532
}
2633

2734
fn prom_remote_write_source(addr: SocketAddr) -> PrometheusRemoteWriteConfig {

0 commit comments

Comments
 (0)