Skip to content

Switch off enableOnBackInvokedCallback due to androidx bug (#1517) #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Switch off enableOnBackInvokedCallback due to androidx bug (#1517) #1517

merged 2 commits into from
Oct 9, 2023

Conversation

julioromano
Copy link

Switch off enableOnBackInvokedCallback until https://issuetracker.google.com/issues/271303558 is fixed.

Fixes #1461

@julioromano julioromano requested a review from a team as a code owner October 9, 2023 08:05
@julioromano julioromano requested review from jmartinesp, bmarty and ganfra and removed request for a team and jmartinesp October 9, 2023 08:05
@julioromano julioromano self-assigned this Oct 9, 2023
@julioromano julioromano changed the title Add more tests, particularly to the room list diffing (#1508) Switch off enableOnBackInvokedCallback due to androidx bug (#1517) Oct 9, 2023
@julioromano julioromano enabled auto-merge (squash) October 9, 2023 08:07
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (776d935) 58.97% compared to head (0156751) 58.97%.

❗ Current head 0156751 differs from pull request most recent head 95941bf. Consider uploading reports for the commit 95941bf to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1517   +/-   ##
========================================
  Coverage    58.97%   58.97%           
========================================
  Files         1133     1133           
  Lines        30307    30307           
  Branches      6215     6215           
========================================
  Hits         17873    17873           
  Misses        9761     9761           
  Partials      2673     2673

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ganfra
ganfra approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HBCnj4

@julioromano julioromano merged commit 794ad4a into develop Oct 9, 2023
@julioromano julioromano deleted the julioromano/fixBackButton branch October 9, 2023 08:39
@julioromano julioromano mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

@bmarty bmarty Awaiting requested review from bmarty

Assignees

@julioromano julioromano

Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to close Screen Room Attachement screen with Android's Back button
3 participants
@julioromano @ganfra @bmarty