Fix issue on analytics setting link

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

The analytics policy link was not used on the setting screen. The PR adds it.

Also migrate the preference to ListItem, and fix a smaller issue on the Analytics OptInScreen.

Note: screenshots are getting recorded and I will add a changelog file once the commit with screeshot has been pushed.

Motivation and context

Fixes #1174

Screenshots / GIFs

Tests

• Go to the settings and click on the link. Note: the current policy link it downloaded a PDF file, but it should still work.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JfzAvk

[codecov]

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.05% 🎉

Comparison is base (5a85459) 56.87% compared to head (706896a) 56.92%.
Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1177      +/-   ##
===========================================
+ Coverage    56.87%   56.92%   +0.05%     
===========================================
  Files         1039     1039              
  Lines        26812    26827      +15     
  Branches      5544     5546       +2     
===========================================
+ Hits         15248    15270      +22     
+ Misses        9168     9161       -7     
  Partials      2396     2396              

Files Changed	Coverage Δ
...id/libraries/designsystem/text/AnnotatedStrings.kt	68.08% <71.42%> (+10.58%)	⬆️
...roid/features/analytics/impl/AnalyticsOptInView.kt	66.01% <77.77%> (-1.00%)	⬇️
...lytics/api/preferences/AnalyticsPreferencesView.kt	60.71% <85.00%> (+1.89%)	⬆️
.../timeline/components/event/TimelineItemTextView.kt	63.88% <85.71%> (-6.70%)	⬇️
...aries/designsystem/theme/components/ListSection.kt	75.38% <87.50%> (+7.64%)	⬆️
...ytics/api/preferences/AnalyticsPreferencesState.kt	100.00% <100.00%> (ø)
...i/preferences/AnalyticsPreferencesStateProvider.kt	87.50% <100.00%> (+1.78%)	⬆️
...references/DefaultAnalyticsPreferencesPresenter.kt	81.25% <100.00%> (+1.25%)	⬆️
...aries/designsystem/components/ClickableLinkText.kt	45.05% <100.00%> (+3.29%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[bmarty]

Can be approved and merge I think.

[jmartinesp]

LGTM, thanks!