Skip to content

Use alpha version of the library androidx.security:security-crypto #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 21, 2023

To fix crash RuntimeException "No matching key found for the ciphertext in the stream".

Fixes #1099

…to fix crash `RuntimeException "No matching key found for the ciphertext in the stream" - RandomSecretPassphraseProvider`. #1099
@bmarty bmarty requested a review from a team as a code owner August 21, 2023 10:58
@bmarty bmarty requested review from jmartinesp and removed request for a team August 21, 2023 10:58
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't be sure until we release a new version with this change, but at least it didn't break anything else in my tests. LGTM!

@jmartinesp
Copy link
Member

jmartinesp commented Aug 21, 2023

It seems like there's some work left to migrate deprecated APIs.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f77b45) 57.14% compared to head (1f9bdaa) 57.14%.

❗ Current head 1f9bdaa differs from pull request most recent head 8fea775. Consider uploading reports for the commit 8fea775 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1101   +/-   ##
========================================
  Coverage    57.14%   57.14%           
========================================
  Files         1021     1021           
  Lines        26072    26072           
  Branches      5272     5272           
========================================
  Hits         14900    14900           
  Misses        8868     8868           
  Partials      2304     2304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/r3jePU

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty
Copy link
Member Author

bmarty commented Aug 21, 2023

Test of app logged in using the previous API and application upgrade OK.

@bmarty bmarty merged commit af04cef into develop Aug 21, 2023
@bmarty bmarty deleted the feature/bma/fixGoogleCryptoCrash branch August 21, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash RuntimeException "No matching key found for the ciphertext in the stream" - RandomSecretPassphraseProvider
2 participants