-
Notifications
You must be signed in to change notification settings - Fork 232
"View only" polls in the timeline #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"View only" polls in the timeline #1031
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
0cfc81e
to
35f163b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1031 +/- ##
===========================================
- Coverage 56.91% 56.87% -0.04%
===========================================
Files 997 1012 +15
Lines 25343 25624 +281
Branches 5077 5137 +60
===========================================
+ Hits 14424 14574 +150
- Misses 8696 8796 +100
- Partials 2223 2254 +31
☔ View full report in Codecov by Sentry. |
8c22d12
to
c011768
Compare
581e43a
to
eabdb95
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but when you say:
The timestamp in the bubble overlaps the total votes label, this issue should be addressed in a dedicated PR as this is not specific to polls
Couldn't we just add an extra bottom padding to make sure they won't ever overlap?
Just found "how" to handle this case in the designs, this is a little trickier as we should only apply padding if the timestamp overlaps content |
I think that's ok for text messages, but for complex ones as polls, location, etc. I'd expect it to be placed below the event contents. In any case we don't have the final designs, so it's not a blocker. |
This PR renders the polls created with other clients.
Notes
matrix-rust-sdk
to be able to see the polls in the timeline. The screenshots are real, but they have been taken while using a custom development branch for the matrix-rust-sdkScreenshots