address coderabbit's comments

* test realistic forward loop started giving meta_offset=[-4098, 0] instead of meta_offset=[-oo, 0], which looks like a fixed bug
Signed-off-by: Elazar Gershuni <[email protected]>

Author: elazarg

src/crab/var_registry.cpp

@@ -172,7 +172,11 @@ Variable VariableRegistry::cell_var(const DataKind array, const Number& offset,
 // Given a type variable, get the associated variable of a given kind.
 Variable VariableRegistry::kind_var(const DataKind kind, const Variable type_variable) {
     const std::string name = VariableRegistry::name(type_variable);
-    return make(name.substr(0, name.rfind('.') + 1) + name_of(kind));
+    const auto dot_pos = name.rfind('.');
+    if (dot_pos == std::string::npos) {
+        CRAB_ERROR("Variable name '", name, "' does not contain a dot");
+    }
+    return make(name.substr(0, dot_pos + 1) + name_of(kind));
 }
 
 Variable VariableRegistry::meta_offset() { return make("meta_offset"); }

src/crab_utils/stats.cpp

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 #include "stats.hpp"
 
+#include <algorithm>
 #include <iostream>
 #include <optional>
 #ifdef _WIN32

src/crab_utils/stats.hpp

@@ -5,7 +5,6 @@
 #include <map>
 #include <string>
 
-#include "arith/variable.hpp"
 #include "crab_utils/lazy_allocator.hpp"
 
 namespace prevail {

src/string_constraints.hpp

@@ -3,6 +3,7 @@
 
 #pragma once
 
+#include <optional>
 #include <regex>
 #include <set>
 #include <string>