Skip to content

Commit c774a25

Browse files
authored
[#137] IntelliJ 2024.3.1.1, sbt-idea-plugin 3.26.2 (#145)
+ Remove deprecated apache logger; use com.intellij.openapi.diagnostic.Logger instead
1 parent ec75828 commit c774a25

File tree

4 files changed

+21
-15
lines changed

4 files changed

+21
-15
lines changed

build.sbt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ lazy val commonSettings = Seq(
1313
"--add-opens", "java.desktop/sun.font=ALL-UNNAMED",
1414
"--add-exports", "java.base/jdk.internal.vm=ALL-UNNAMED",
1515
),
16-
version := "2024.3",
16+
version := "2024.3.1.1",
1717
scalaVersion := "2.13.15",
1818
libraryDependencies ++= Seq(
1919
"junit" % "junit" % "4.13.2" % Test,
@@ -30,17 +30,17 @@ lazy val `cucumber-scala` = project
3030
.settings(
3131
commonSettings,
3232
ThisBuild / intellijPluginName := "intellij-cucumber-scala",
33-
ThisBuild / intellijBuild := "243.21565.193",
33+
ThisBuild / intellijBuild := "243.22562.218",
3434
ThisBuild / intellijPlatform := IntelliJPlatform.IdeaCommunity,
3535
Compile / javacOptions ++= "--release" :: "21" :: Nil,
3636
intellijPlugins ++= Seq(
37-
"org.intellij.scala:2024.3.18".toPlugin,
38-
"gherkin:243.21565.122".toPlugin
37+
"org.intellij.scala:2024.3.23".toPlugin,
38+
"gherkin:243.22562.13".toPlugin
3939
),
4040
packageMethod := PackagingMethod.Standalone(),
4141
patchPluginXml := pluginXmlOptions { xml =>
4242
xml.version = version.value
43-
xml.sinceBuild = "243.21565"
43+
xml.sinceBuild = "243.22562"
4444
xml.untilBuild = "243.*"
4545
},
4646
signPluginOptions := signPluginOptions.value.copy(enabled = true)

cucumber-scala/src/main/resources/META-INF/plugin.xml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<id>com.github.danielwegener.cucumber-scala</id>
66
<name>Cucumber for Scala</name>
77
<category>Test Tools</category>
8-
<version>2024.3</version>
9-
<idea-version since-build="243.21565" until-build="243.*"/>
8+
<version>2024.3.1.1</version>
9+
<idea-version since-build="243.22562" until-build="243.*"/>
1010
<vendor email="[email protected]" url="https://github.com/vbmacher">Peter Jakubčo</vendor>
1111

1212
<description><![CDATA[
@@ -19,12 +19,21 @@
1919

2020
<change-notes><![CDATA[
2121
<ul>
22+
<li>2024.3.1.1: Release for IntelliJ 2024.3.1.1 (build 243.22562.218)
23+
<ol>
24+
<li>Scala plugin 2024.3.23</li>
25+
<li>Gherkin plugin 243.22562.13</li>
26+
<li><a href="https://github.com/vbmacher/intellij-cucumber-scala/issues/137">Problem with building in GitHub actions</a></li>
27+
<li>Rollback to using Java version 17 (which is default IntelliJ Idea Java version)</li>
28+
</ol>
29+
</li>
2230
<li>2024.3: Release for IntelliJ 2024.3 (build 243.21565.193)
2331
<ol>
2432
<li>Scala plugin 2024.3.18</li>
2533
<li>Gherkin plugin 243.21565.122</li>
2634
<li>cucumber-scala 8.25.1</li>
2735
<li>cucumber-junit 7.20.1</li>
36+
<li>Use Java version 21</li>
2837
</ol>
2938
</li>
3039
<li>2024.2.1: Release for IntelliJ 2024.2.1 (build 242.21829.142)

cucumber-scala/src/test/scala/com/github/vbmacher/intellij/cucumber/scala/ScCucumberSpecBase.scala

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@ package com.github.vbmacher.intellij.cucumber.scala
33
import com.intellij.codeInsight.daemon.LineMarkerInfo
44
import com.intellij.codeInsight.daemon.impl.DaemonCodeAnalyzerImpl.getLineMarkers
55
import com.intellij.psi._
6-
import com.intellij.testFramework.UsefulTestCase
76
import com.intellij.testFramework.fixtures.BasePlatformTestCase
8-
import org.apache.log4j.Logger
7+
import com.intellij.openapi.diagnostic.Logger
98
import org.scalatest.matchers.should.Matchers
109
import org.scalatestplus.junit.JUnitSuiteLike
1110

1211
import java.io.File
1312
import scala.jdk.CollectionConverters._
1413

1514
abstract class ScCucumberSpecBase extends BasePlatformTestCase with Matchers with JUnitSuiteLike {
16-
protected lazy val LOG = Logger.getRootLogger
15+
protected lazy val LOG = Logger.getInstance(classOf[ScCucumberSpecBase])
1716

1817
val DESCRIPTOR = new LibraryLightProjectDescriptor(
1918
//RemoteDependency("io.cucumber:cucumber-scala_2.13:6.9.0")
@@ -32,14 +31,12 @@ abstract class ScCucumberSpecBase extends BasePlatformTestCase with Matchers wit
3231

3332
def findLineMarkers() = {
3433
val editor = myFixture.getEditor
35-
val project = myFixture.getProject
34+
val project = getProject
3635

3736
myFixture.doHighlighting()
3837

3938
var lineMarkers = collection.mutable.Seq.empty[LineMarkerInfo[_]]
40-
UsefulTestCase.edt(() => {
41-
getLineMarkers(editor.getDocument, project).asScala.foreach(lineMarkers +:= _)
42-
})
39+
inWriteAction(getLineMarkers(editor.getDocument, project).asScala.foreach(lineMarkers +:= _))
4340

4441
lineMarkers
4542
}

project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
addSbtPlugin("org.jetbrains" % "sbt-idea-plugin" % "3.20.1")
1+
addSbtPlugin("org.jetbrains" % "sbt-idea-plugin" % "3.26.2")

0 commit comments

Comments
 (0)