Skip to content

Commit c7b9d0d

Browse files
committed
feat(accordion): migrated to standalone
1 parent d942ade commit c7b9d0d

File tree

7 files changed

+38
-39
lines changed

7 files changed

+38
-39
lines changed

libs/common-docs/src/lib/common/schematics/schematics.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ <h2 id="getting-started">Schematics</h2>
138138
],
139139
<span class="kwd">imports</span>: [
140140
<span class="pln"> &hellip;</span>
141-
<span class="lit">AccordionModule.forRoot()</span>,
141+
<span class="lit">AccordionModule</span>,
142142
],
143143
bootstrap: [AppComponent]
144144
<span class="pun">{{'}'}}</span>)

libs/doc-pages/accordion/src/lib/accordion.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export { AccordionSectionComponent } from './accordion-section.component';
1717
...DEMO_COMPONENTS
1818
],
1919
imports: [
20-
AccordionModule.forRoot(),
20+
AccordionModule,
2121
CommonModule,
2222
FormsModule,
2323
DocsModule,

libs/doc-pages/accordion/src/lib/docs/usage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { AccordionModule } from 'ngx-bootstrap/accordion';
55
@NgModule({
66
imports: [
77
BrowserAnimationsModule,
8-
AccordionModule.forRoot(),
8+
AccordionModule,
99
...
1010
]
1111
})

src/accordion/accordion-group.component.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import {
22
Component, HostBinding, Inject, Input, OnDestroy, OnInit, Output, EventEmitter
33
} from '@angular/core';
44
import { AccordionComponent } from './accordion.component';
5+
import { CollapseModule } from 'ngx-bootstrap/collapse';
6+
import { NgClass, NgIf } from '@angular/common';
57

68
/**
79
* ### Accordion heading
@@ -10,14 +12,16 @@ import { AccordionComponent } from './accordion.component';
1012
* will be used as group's header template.
1113
*/
1214
@Component({
13-
selector: 'accordion-group, accordion-panel',
14-
templateUrl: './accordion-group.component.html',
15-
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
16-
host: {
17-
class: 'panel',
18-
style: 'display: block'
19-
},
20-
styleUrls: ['./accordion.scss']
15+
selector: 'accordion-group, accordion-panel',
16+
templateUrl: './accordion-group.component.html',
17+
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
18+
host: {
19+
class: 'panel',
20+
style: 'display: block'
21+
},
22+
styleUrls: ['./accordion.scss'],
23+
standalone: true,
24+
imports: [NgClass, NgIf, CollapseModule]
2125
})
2226
export class AccordionPanelComponent implements OnInit, OnDestroy {
2327
/** turn on/off animation */

src/accordion/accordion.component.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,16 @@ import { AccordionConfig } from './accordion.config';
44

55
/** Displays collapsible content panels for presenting information in a limited amount of space. */
66
@Component({
7-
selector: 'accordion',
8-
template: `<ng-content></ng-content>`,
9-
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
10-
host: {
11-
'[attr.aria-multiselectable]': 'closeOthers',
12-
role: 'tablist',
13-
class: 'panel-group',
14-
style: 'display: block'
15-
}
7+
selector: 'accordion',
8+
template: `<ng-content></ng-content>`,
9+
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
10+
host: {
11+
'[attr.aria-multiselectable]': 'closeOthers',
12+
role: 'tablist',
13+
class: 'panel-group',
14+
style: 'display: block'
15+
},
16+
standalone: true
1617
})
1718
export class AccordionComponent {
1819
/** turn on/off animation */

src/accordion/accordion.module.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,10 @@
1-
import { CommonModule } from '@angular/common';
2-
import { NgModule, ModuleWithProviders } from '@angular/core';
1+
import { NgModule } from '@angular/core';
32

43
import { AccordionComponent } from './accordion.component';
54
import { AccordionPanelComponent } from './accordion-group.component';
6-
import { CollapseModule } from 'ngx-bootstrap/collapse';
75

86
@NgModule({
9-
imports: [CommonModule, CollapseModule],
10-
declarations: [AccordionComponent, AccordionPanelComponent],
11-
exports: [AccordionComponent, AccordionPanelComponent]
7+
imports: [AccordionComponent, AccordionPanelComponent],
8+
exports: [AccordionComponent, AccordionPanelComponent]
129
})
13-
export class AccordionModule {
14-
static forRoot(): ModuleWithProviders<AccordionModule> {
15-
return { ngModule: AccordionModule, providers: [] };
16-
}
17-
}
10+
export class AccordionModule {}

src/accordion/testing/accordion.component.spec.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
44
import { AccordionConfig, AccordionModule } from '../index';
55

66
@Component({
7-
selector: 'accordion-test',
8-
template: ''
7+
selector: 'accordion-test',
8+
template: '',
9+
standalone: true
910
})
1011
class TestAccordionComponent {
1112
oneAtATime = true;
@@ -75,12 +76,12 @@ describe('Component: Accordion', () => {
7576

7677
beforeEach(() => {
7778
TestBed.configureTestingModule({
78-
declarations: [TestAccordionComponent],
79-
imports: [
80-
AccordionModule.forRoot(),
81-
BrowserAnimationsModule
82-
]
83-
});
79+
imports: [
80+
AccordionModule,
81+
BrowserAnimationsModule,
82+
TestAccordionComponent
83+
]
84+
});
8485
TestBed.overrideComponent(TestAccordionComponent, {
8586
set: { template: html }
8687
});

0 commit comments

Comments
 (0)