Deduplicate workflows, cleaner naming

Author: strinnityk

.github/workflows/base_daily.yml renamed to .github/workflows/base_tests.yml

@@ -1,4 +1,4 @@
-name: Daily
+name: Base Tests
 
 on:
   push:
@@ -7,14 +7,11 @@ on:
   pull_request:
   workflow_call:
     inputs:
-      nim-branch:
-        description: 'Nim branch'
-        required: true
-        type: string
-      cpu:
-        description: 'CPU'
-        required: true
+      include:
+        description: 'Include matrix configurations'
+        required: false
         type: string
+        default: "[]"
       exclude:
         description: 'Exclude matrix configurations'
         required: false
@@ -26,13 +23,13 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  delete-cache:
+  delete_cache:
     runs-on: ubuntu-latest
     steps:
       - uses: snnaplab/delete-branch-cache-action@v1
 
   test:
-    needs: delete-cache
+    needs: delete_cache
     timeout-minutes: 90
     strategy:
       fail-fast: false
@@ -54,13 +51,10 @@ jobs:
             builder: windows-2019
             cpu: amd64
             shell: msys2 {0}
-          # - os: windows
-          #   builder: windows-2019
-          #   cpu: i386
-          #   shell: msys2 {0}
         nim-branch:
           - version-1-6
           - version-2-0
+        include: ${{ fromJSON(inputs.include) }}
         exclude: ${{ fromJSON(inputs.exclude) }}
 
     defaults:

.github/workflows/ci.yml

@@ -1,7 +1,7 @@
-name: Codecov
+name: Coverage
 
 on:
-  #On push to common branches, this computes the "bases stats" for PRs
+  # On push to common branches, this computes the coverage PRs will compared against
   push:
     branches:
       - master
@@ -15,7 +15,8 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  coverage:
+  codecov:
+    # Improvement: Split single job into run tests, generate coverage, and upload to codecov.
     name: Run coverage and upload to codecov
     runs-on: ubuntu-20.04
     env:

.github/workflows/codecov.yml renamed to .github/workflows/coverage.yml

@@ -5,24 +5,21 @@ on:
   workflow_dispatch:
 
 jobs:
-  call-multi-nim-common:
+  test_amd64:
     name: Daily amd64
-    uses: ./.github/workflows/base_daily.yml
+    uses: ./.github/workflows/base_tests.yml
     with:
-      nim-branch: "['version-1-6','version-2-0']"
-      cpu: "['amd64']"
+      exclude: "[{'platform': {'cpu': 'amd64'}}]"
 
-  call-multi-nim-common:
+  test_i386:
     name: Daily i386
-    uses: ./.github/workflows/base_daily.yml
+    uses: ./.github/workflows/base_tests.yml
     with:
-      nim-branch: "['version-1-6','version-2-0', 'devel']"
-      cpu: "['i386']"
-      exclude: "[{'platform': {'os':'macos'}}, {'platform': {'os':'windows'}}]"
+      exclude: "[{'platform': {'cpu': 'i386'}}]"
 
-  call-multi-nim-common:
-    name: Daily Nim Devel
-    uses: ./.github/workflows/base_daily.yml
+  test_nim_devel:
+    name: Daily 
+    uses: ./.github/workflows/base_tests.yml
     with:
-      nim-branch: "['devel']"
-      cpu: "['amd64']"
+      include: "[{'nim-branch': ['devel']}]"
+      exclude: "[{'platform': {'os': 'linux', 'cpu': 'amd64'}}]"

.github/workflows/daily.yml

@@ -1,14 +1,15 @@
-name: Dependency Bumper
+name: Update this project's version where it servers as a dependency
 on:
   push:
     branches:
       - master
   workflow_dispatch:
 
 jobs:
-  bumpProjects:
+  update_version:
+    # Is this job necessary?
     runs-on: ubuntu-latest
-    name: Bump version on ${{ matrix.target.repo }}:${{ matrix.target.branch }}
+    name: Updating version on ${{ matrix.target.repo }}:${{ matrix.target.branch }}
     strategy:
       fail-fast: false
       matrix:
@@ -35,6 +36,7 @@ jobs:
           git checkout $GITHUB_SHA
 
       - name: Commit this bump
+        # Is it mandatory to create a new commit? Or does it exist as a way to communicate why the version was updated.
         run: |
           cd nbc
           git config --global user.email "${{ github.actor }}@users.noreply.github.com"

.github/workflows/bumper.yml renamed to .github/workflows/dependencies.yml

@@ -1,6 +1,8 @@
-name: Docgen
+name: Documentation generation and publishing
 on:
   push:
+    branches:
+      - master
   workflow_dispatch:
 
 

.github/workflows/doc.yml renamed to .github/workflows/documentation.yml

@@ -1,9 +1,9 @@
-name: Interoperability Testing
+name: Interoperability Tests
 on:
   pull_request:
   push:
     branches:
-      - unstable
+      - master
   workflow_dispatch:
 
 concurrency: