Skip to content

Commit 68d5f91

Browse files
johanCommit bot
authored andcommitted
Fix build on solaris platforms
e8b9f2d introduced a different cast which broke building on Illumos. Revert to previous behavior for V8_OS_SOLARIS only. Found on SmartOS while building with gcc 4.9.0. edit1: adding jochen to reviewers since he was assigned through the issue tracker and danno since he seems to do a fair amount of cross-platform work edit2: removing BUG reference because I don't understand what LOG needs to contain (and it seems to link to chromium and not the v8 repo). Please edit commit message as appropriate. BUG=3935 LOG=n Review URL: https://codereview.chromium.org/990063002 Cr-Commit-Position: refs/heads/master@{#27163}
1 parent 1a37a4c commit 68d5f91

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ Jay Freeman <[email protected]>
6262
James Pike <[email protected]>
6363
Jianghua Yang <[email protected]>
6464
Joel Stanley <[email protected]>
65+
Johan Bergström <[email protected]>
6566
Jonathan Liu <[email protected]>
6667
JunHo Seo <[email protected]>
6768
Kang-Hao (Kenny) Lu <[email protected]>

src/base/platform/platform-posix.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,8 @@ int OS::GetCurrentThreadId() {
273273
return static_cast<int>(gettid());
274274
#elif V8_OS_AIX
275275
return static_cast<int>(thread_self());
276+
#elif V8_OS_SOLARIS
277+
return static_cast<int>(pthread_self());
276278
#else
277279
return static_cast<int>(reinterpret_cast<intptr_t>(pthread_self()));
278280
#endif

0 commit comments

Comments
 (0)