CS-57: Fix threading for TSC and fix CI for bionic nodejs version incompatibility (#421)

* CS-57: Fix threading for TSC and fix CI for bionic nodejs version imcompatibility

* Updates

Author: paulbourelly999

.github/workflows/feature_branch.yml

@@ -2,6 +2,11 @@ name: feature_branch
 on:
   pull_request:
     types: [opened, synchronize, reopened]
+# make GHA actions use node16 which still works with bionic
+# See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
+# Unclear how long this will work though. Remove after rebase carma-streets to newer Ubuntu release
+env:
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
 jobs:       
   build:
     defaults:

.github/workflows/master.yml

@@ -2,6 +2,11 @@ name: master
 on:
   push:
     branches: [master]
+# make GHA actions use node16 which still works with bionic
+# See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
+# Unclear how long this will work though. Remove after rebase carma-streets to newer Ubuntu release
+env:
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
 jobs:
   docker-build:
     strategy:

.github/workflows/release.yml

@@ -3,6 +3,11 @@ on:
   push:
     tags: 
       - "carma-system-*"
+# make GHA actions use node16 which still works with bionic
+# See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
+# Unclear how long this will work though. Remove after rebase carma-streets to newer Ubuntu release
+env:
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
 jobs:
   docker-build:
     strategy:

tsc_client_service/src/tsc_service.cpp

@@ -389,7 +389,7 @@ namespace traffic_signal_controller_service {
                     // Log command info sent
                     SPDLOG_INFO(command_to_execute.get_cmd_info());                
                     if ( enable_snmp_cmd_logging_ ){
-                        if(auto logger = spdlog::get("snmp_cmd_logger"); logger != nullptr ){
+                        if(auto logger = spdlog::get(SNMP_COMMAND_LOGGER_NAME); logger != nullptr ){
                             logger->info( command_to_execute.get_cmd_info());
                         }
                     }
@@ -453,11 +453,13 @@ namespace traffic_signal_controller_service {
         std::thread spat_t(&tsc_service::produce_spat_json, this);
 
         if ( spat_proj_mode == SPAT_PROJECTION_MODE::DPP_PROJECTION ) {
+            // Run thread to consume dpp
             std::thread desired_phase_plan_t(&tsc_service::consume_desired_phase_plan, this);
-            SPDLOG_DEBUG("Thread joined to consume desired phase plan generated by carma-streets SO service.");
-            desired_phase_plan_t.join();
+            SPDLOG_DEBUG("Thread joined to consume desired phase plan generated by carma-streets SO service and send SNMP commands");
             // Run tsc control phases
             std::thread control_phases_t(&tsc_service::control_tsc_phases, this);
+
+            desired_phase_plan_t.join();
             control_phases_t.join();
         }
         // TODO: Remove if no longer necessary for TM/TSP MMITSS Integration