Skip to content

fix: respect useDefineForClassFields=false setting #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Apr 7, 2025

Description

This setting defaults to true, so if not explicitly set to false, it is not propagated to the transformer.

Linked Issues

vitest-dev/vitest#7805

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@orgads orgads force-pushed the use-define-false branch from 5935f44 to dd97210 Compare April 7, 2025 14:50
@orgads orgads changed the title Respect useDefineForClassFields=false setting fix: respect useDefineForClassFields=false setting Apr 7, 2025
@orgads orgads force-pushed the use-define-false branch from dd97210 to 44e2a38 Compare April 7, 2025 14:58
@orgads
Copy link
Contributor Author

orgads commented Apr 16, 2025

@hannoeru ping

This setting defaults to true, so if not explicitly set to false, it
is not propagated to the transformer.

See vitest-dev/vitest#7805
@orgads orgads force-pushed the use-define-false branch from 44e2a38 to 463978d Compare April 16, 2025 09:34
@orgads
Copy link
Contributor Author

orgads commented Apr 22, 2025

@hannoeru Anything else?

@hannoeru hannoeru merged commit db919e3 into unplugin:main Apr 22, 2025
6 checks passed
@orgads orgads deleted the use-define-false branch April 22, 2025 06:06
@orgads
Copy link
Contributor Author

orgads commented Apr 22, 2025

Thank you.

Copy link

🎉 This PR is included in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants