Skip to content

Should the version of pydantic be pinned? #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PetitLepton opened this issue Jul 3, 2023 · 2 comments
Closed

Should the version of pydantic be pinned? #1245

PetitLepton opened this issue Jul 3, 2023 · 2 comments
Labels
question Further information is requested

Comments

@PetitLepton
Copy link

Question about pandera

Hi, if I am not mistaken, pandera requires the installation of pydantic, here but does not ping any version. This leads to some issues if no other package imposes pydantic version to be strictly below version 2 as pandera would currently install pydantic version 2.

For example, it broke our CI this morning when used in pre-commit like the following

repos:
  - repo: https://github.com/pre-commit/mirrors-mypy
    rev: v1.4.1
    hooks:
      - id: mypy
        additional_dependencies:
          - pandera[mypy]==0.13.4

and took us a while to understand the issue (and fix it by adding the version of pydantic in the pre-commit file). Do you think it would be worth pinging the pydantic version to stay below 2?

Thanks in advance,
F.

@PetitLepton PetitLepton added the question Further information is requested label Jul 3, 2023
@PetitLepton PetitLepton changed the title Should the version of Pydantic be pinged Should the version of Pydantic be pinged? Jul 3, 2023
@PetitLepton PetitLepton changed the title Should the version of Pydantic be pinged? Should the version of pydantic be pinged? Jul 3, 2023
@PetitLepton PetitLepton changed the title Should the version of pydantic be pinged? Should the version of pydantic be pinned? Jul 4, 2023
This was referenced Jul 6, 2023
@cosmicBboy
Copy link
Collaborator

I made this PR: #1253 that adds provisional support for pydantic, i.e. all the existing unit tests pass with the existing pydantic syntax. There're probably going to more bugs/issues once folks veer off the tested path, but we can tackle those as they come. Will release this as part of 0.16.0.

In the mean time, I'll make a patch release 0.15.2 that pins pydantic so it doesn't continue breaking people's CI.

This was referenced Jul 6, 2023
@cosmicBboy
Copy link
Collaborator

fixed by #1255. created issue to track v2 support #1257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants