Skip to content

Commit a1555e5

Browse files
authored
Reduce MSRV for zerofrom back to 1.71.1 (#6312)
As discussed in #6192 (comment).
1 parent f67645a commit a1555e5

File tree

4 files changed

+36
-2
lines changed

4 files changed

+36
-2
lines changed

.github/workflows/build-test.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,30 @@ jobs:
7676
- name: Check
7777
run: cargo make ci-job-msrv-${{ matrix.behavior }}
7878

79+
msrv-zerofrom:
80+
runs-on: ubuntu-latest
81+
# Defined as a matrix so that features can start immediately, but
82+
# be killed if check fails.
83+
strategy:
84+
fail-fast: true
85+
# Set CARGO_HTTP_MULTIPLEXING=false to work around crates.io curl bug:
86+
# <https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/timeout.20investigation>
87+
env:
88+
CARGO_HTTP_MULTIPLEXING: false
89+
steps:
90+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
91+
92+
# Cargo-make boilerplate
93+
- name: Install cargo-make
94+
uses: taiki-e/install-action@64e4e2f995104968c78bd697b253d55bf557af66 # v2.41.11
95+
with:
96+
97+
98+
# No toolchain boilerplate as this runs on MSRV
99+
100+
# Actual job
101+
- name: Check
102+
run: cargo make ci-job-msrv-zerofrom
79103

80104
# ci-job-test
81105
test:

Makefile.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,16 @@ exec --fail-on-error rustup install 1.81 --profile minimal
6565
exec --fail-on-error cargo +1.81 check --all-targets --all-features
6666
'''
6767

68+
[tasks.ci-job-msrv-zerofrom]
69+
description = "Run MSRV tests for the zerofrom MSRV job"
70+
category = "ICU4X Development"
71+
env = { ICU4X_DATA_DIR = "../stubdata" }
72+
script_runner = "@duckscript"
73+
script = '''
74+
exec --fail-on-error rustup install 1.71.1 --profile minimal
75+
exec --fail-on-error cargo +1.71.1 check -p zerofrom --all-targets --all-features
76+
'''
77+
6878
[tasks.ci-job-test]
6979
description = "Run all tests for the CI 'test' job"
7080
category = "CI"

utils/zerofrom/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ edition.workspace = true
1414
include.workspace = true
1515
license.workspace = true
1616
repository.workspace = true
17-
rust-version.workspace = true
17+
rust-version = "1.71.1"
1818

1919
[package.metadata.workspaces]
2020
independent = true

utils/zerofrom/derive/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ keywords = ["zerocopy", "serialization", "lifetime", "borrow"]
1313
edition.workspace = true
1414
license.workspace = true
1515
repository.workspace = true
16+
rust-version = "1.71.1"
1617

1718
[package.metadata.workspaces]
1819
independent = true
@@ -30,4 +31,3 @@ synstructure = { workspace = true }
3031
[dev-dependencies]
3132
zerofrom = { path = "..", features = ["derive"]}
3233
zerovec = { path = "../../../utils/zerovec", features = ["yoke"] }
33-

0 commit comments

Comments
 (0)