Add FFI for Property Enums (#5841)

Fixes #4686

We removed BidiAuxiliaryProps, it seems, so this doesn't add that. It
also doesn't add enum-to-name at the moment, we can add later if we
wish.

Author: Manishearth

components/properties/src/props.rs

@@ -30,7 +30,7 @@ pub use crate::bidi::{BidiMirroringGlyph, BidiPairedBracketType};
 ///     ...
 /// }
 /// ```
-/// Produces `const ALL_CONSTS = &[("Neutral", 0u16), ...];` by
+/// Produces `const ALL_VALUES = &[("Neutral", 0u16), ...];` by
 /// explicitly casting first field of the struct to u16.
 macro_rules! create_const_array {
     (
@@ -46,11 +46,19 @@ macro_rules! create_const_array {
                 $v const $i: $t = $e;
             )*
 
-            #[cfg(test)]
-            const ALL_CONSTS: &'static [(&'static str, u16)] = &[
-                $((stringify!($i), $enum_ty::$i.0 as u16)),*
+            /// All possible values of this enum in the Unicode version
+            /// from this ICU4X release.
+            pub const ALL_VALUES: &'static [$enum_ty] = &[
+                $($enum_ty::$i),*
             ];
         }
+
+
+        impl From<$enum_ty> for u16  {
+            fn from(other: $enum_ty) -> Self {
+                other.0 as u16
+            }
+        }
     }
 }
 
@@ -269,6 +277,42 @@ pub(crate) mod gc {
 
 pub use gc::GeneralCategory;
 
+impl GeneralCategory {
+    /// All possible values of this enum
+    pub const ALL_VALUES: &'static [GeneralCategory] = &[
+        GeneralCategory::Unassigned,
+        GeneralCategory::UppercaseLetter,
+        GeneralCategory::LowercaseLetter,
+        GeneralCategory::TitlecaseLetter,
+        GeneralCategory::ModifierLetter,
+        GeneralCategory::OtherLetter,
+        GeneralCategory::NonspacingMark,
+        GeneralCategory::SpacingMark,
+        GeneralCategory::EnclosingMark,
+        GeneralCategory::DecimalNumber,
+        GeneralCategory::LetterNumber,
+        GeneralCategory::OtherNumber,
+        GeneralCategory::SpaceSeparator,
+        GeneralCategory::LineSeparator,
+        GeneralCategory::ParagraphSeparator,
+        GeneralCategory::Control,
+        GeneralCategory::Format,
+        GeneralCategory::PrivateUse,
+        GeneralCategory::Surrogate,
+        GeneralCategory::DashPunctuation,
+        GeneralCategory::OpenPunctuation,
+        GeneralCategory::ClosePunctuation,
+        GeneralCategory::ConnectorPunctuation,
+        GeneralCategory::InitialPunctuation,
+        GeneralCategory::FinalPunctuation,
+        GeneralCategory::OtherPunctuation,
+        GeneralCategory::MathSymbol,
+        GeneralCategory::CurrencySymbol,
+        GeneralCategory::ModifierSymbol,
+        GeneralCategory::OtherSymbol,
+    ];
+}
+
 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug, Hash, Default)]
 /// Error value for `impl TryFrom<u8> for GeneralCategory`.
 #[non_exhaustive]
@@ -620,6 +664,7 @@ impl From<GeneralCategoryGroup> for u32 {
 #[repr(transparent)]
 pub struct Script(pub u16);
 
+create_const_array! {
 #[allow(missing_docs)] // These constants don't need individual documentation.
 #[allow(non_upper_case_globals)]
 impl Script {
@@ -789,6 +834,7 @@ impl Script {
     pub const Yi: Script = Script(41);
     pub const ZanabazarSquare: Script = Script(177);
 }
+}
 
 make_enumerated_property! {
     name: "Script";
@@ -933,6 +979,7 @@ make_enumerated_property! {
 #[repr(transparent)]
 pub struct LineBreak(pub u8);
 
+create_const_array! {
 #[allow(missing_docs)] // These constants don't need individual documentation.
 #[allow(non_upper_case_globals)]
 impl LineBreak {
@@ -987,6 +1034,7 @@ impl LineBreak {
     pub const ViramaFinal: LineBreak = LineBreak(46); // name=VF"
     pub const Virama: LineBreak = LineBreak(47); // name=VI"
 }
+}
 
 make_enumerated_property! {
     name: "Line_Break";
@@ -1026,6 +1074,7 @@ make_enumerated_property! {
 #[repr(transparent)]
 pub struct GraphemeClusterBreak(pub u8);
 
+create_const_array! {
 #[allow(missing_docs)] // These constants don't need individual documentation.
 #[allow(non_upper_case_globals)]
 impl GraphemeClusterBreak {
@@ -1052,6 +1101,7 @@ impl GraphemeClusterBreak {
     pub const GlueAfterZwj: GraphemeClusterBreak = GraphemeClusterBreak(16); // name="GAZ"
     pub const ZWJ: GraphemeClusterBreak = GraphemeClusterBreak(17); // name="ZWJ"
 }
+}
 
 make_enumerated_property! {
     name: "Grapheme_Cluster_Break";
@@ -2956,19 +3006,28 @@ mod test_enumerated_property_completeness {
     use super::*;
     use alloc::collections::BTreeMap;
 
-    fn check_enum<'a>(
+    fn check_enum<'a, T: NamedEnumeratedProperty>(
         lookup: &crate::provider::names::PropertyValueNameToEnumMapV1<'static>,
-        consts: impl IntoIterator<Item = &'a (&'static str, u16)>,
-    ) {
+        consts: impl IntoIterator<Item = &'a T>,
+    ) where
+        u16: From<T>,
+    {
         let mut data: BTreeMap<_, _> = lookup
             .map
             .iter()
             .map(|(name, value)| (value, (name, "Data")))
             .collect();
 
-        let consts = consts
-            .into_iter()
-            .map(|(name, value)| (*value as usize, (name.to_string(), "Consts")));
+        let names = crate::PropertyNamesLong::<T>::new();
+        let consts = consts.into_iter().map(|value| {
+            (
+                u16::from(*value) as usize,
+                (
+                    names.get(*value).unwrap_or("<unknown>").to_string(),
+                    "Consts",
+                ),
+            )
+        });
 
         let mut diff = Vec::new();
         for t @ (value, _) in consts {
@@ -2994,63 +3053,63 @@ mod test_enumerated_property_completeness {
     fn test_ea() {
         check_enum(
             crate::provider::Baked::SINGLETON_EAST_ASIAN_WIDTH_NAME_TO_VALUE_V2_MARKER,
-            EastAsianWidth::ALL_CONSTS,
+            EastAsianWidth::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_ccc() {
         check_enum(
             crate::provider::Baked::SINGLETON_CANONICAL_COMBINING_CLASS_NAME_TO_VALUE_V2_MARKER,
-            CanonicalCombiningClass::ALL_CONSTS,
+            CanonicalCombiningClass::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_jt() {
         check_enum(
             crate::provider::Baked::SINGLETON_JOINING_TYPE_NAME_TO_VALUE_V2_MARKER,
-            JoiningType::ALL_CONSTS,
+            JoiningType::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_insc() {
         check_enum(
             crate::provider::Baked::SINGLETON_INDIC_SYLLABIC_CATEGORY_NAME_TO_VALUE_V2_MARKER,
-            IndicSyllabicCategory::ALL_CONSTS,
+            IndicSyllabicCategory::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_sb() {
         check_enum(
             crate::provider::Baked::SINGLETON_SENTENCE_BREAK_NAME_TO_VALUE_V2_MARKER,
-            SentenceBreak::ALL_CONSTS,
+            SentenceBreak::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_wb() {
         check_enum(
             crate::provider::Baked::SINGLETON_WORD_BREAK_NAME_TO_VALUE_V2_MARKER,
-            WordBreak::ALL_CONSTS,
+            WordBreak::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_bc() {
         check_enum(
             crate::provider::Baked::SINGLETON_BIDI_CLASS_NAME_TO_VALUE_V2_MARKER,
-            BidiClass::ALL_CONSTS,
+            BidiClass::ALL_VALUES,
         );
     }
 
     #[test]
     fn test_hst() {
         check_enum(
             crate::provider::Baked::SINGLETON_HANGUL_SYLLABLE_TYPE_NAME_TO_VALUE_V2_MARKER,
-            HangulSyllableType::ALL_CONSTS,
+            HangulSyllableType::ALL_VALUES,
         );
     }
 }