Bump nightlies and LLVM (#6411)

Author: robertbastian

.github/workflows/artifacts-build.yml

@@ -267,8 +267,6 @@ jobs:
       run: |
         npm -C ffi/npm ci
         npm -C tutorials/web-demo ci
-      env: 
-        PINNED_CI_NIGHTLY: nightly-2024-07-23
 
     - name: Run Webpack
       run: npm -C tutorials/web-demo run build

.github/workflows/build-test.yml

@@ -280,6 +280,11 @@ jobs:
     - name: Show the selected Rust toolchain
       run: rustup show
 
+    # Job-specific dependencies
+    # TODO: Remove on 2025-05-05, when clang-19 is in ubuntu-latest (https://github.com/actions/runner-images/issues/11895)
+    - name: Install LLD and Clang
+      run: sudo apt-get install lld-19 clang-19
+
     # Actual job
     - name: Run `cargo make ci-job-test-c`
       run: cargo make ci-job-test-c
@@ -310,6 +315,11 @@ jobs:
     - name: Show the selected Rust toolchain
       run: rustup show
 
+    # Job-specific dependencies
+    # TODO: Remove on 2025-05-05, when clang-19 is in ubuntu-latest (https://github.com/actions/runner-images/issues/11895)
+    - name: Install LLD
+      run: sudo apt-get install lld-19
+
     # Actual job
     - name: Run `cargo make ci-job-test-js`
       run: cargo make ci-job-test-js

.github/workflows/coverage.yml

@@ -29,7 +29,7 @@ jobs:
 
       - uses:                   actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # v1.0.7
         with:
-          toolchain:            nightly-2024-07-23
+          toolchain:            nightly-2024-09-01
           override:             true
 
       - run: cargo test --all-features --no-fail-fast

CONTRIBUTING.md

@@ -112,7 +112,7 @@ Our wider testsuite is organized as `ci-job-foo` make tasks corresponding to eac
 <br/>
 
  - `ci-job-test-c`: Runs all C/C++ FFI tests; mostly important if you're changing the FFI interface.
-     + Requires `clang-18` and `lld-18` with the `gold` plugin (APT packages `llvm-18` and `lld-18`).
+     + Requires `clang-19` and `lld-19` with the `gold` plugin (APT packages `llvm-19` and `lld-19`).
  - `ci-job-test-js`: Runs all JS/WASM/Node FFI tests; mostly important if you're changing the FFI interface.
      + Requires Node.js version 16.18.0. This may not the one offered by the package manager; get it from the NodeJS website or `nvm`.
  - `ci-job-nostd`: Builds ICU4X for a `#[no_std]` target to verify that it's compatible.

Cargo.lock

@@ -19,7 +19,7 @@ default_to_workspace = false
 # The toolchain that CI is being run in. Allows tests to change under beta/nightly.
 CI_TOOLCHAIN = { value = "pinned-stable", condition = { env_not_set = ["CI_TOOLCHAIN"]}}
 # The pinned nightly toolchain for jobs that require a nightly compiler.
-PINNED_CI_NIGHTLY = { value = "nightly-2024-07-23", condition = { env_not_set = ["PINNED_CI_NIGHTLY"] } }
+PINNED_CI_NIGHTLY = { value = "nightly-2025-02-17", condition = { env_not_set = ["PINNED_CI_NIGHTLY"] } }
 
 [tasks.quick]
 description = "Run quick version of all lints and builds (useful before pushing to GitHub)"

Makefile.toml

@@ -12,7 +12,7 @@ edition = "2021"
 diplomat_core = { workspace = true }
 elsa = { workspace = true }
 lazy_static = "1"
-rustdoc-types = "0.28"
+rustdoc-types = "0.36"
 serde_json = { workspace = true }
 syn-inline-mod = "0.6.0"
 

tools/make/diplomat-coverage/Cargo.toml

@@ -99,13 +99,13 @@ fn collect_public_types(krate: &str) -> impl Iterator<Item = (Vec<String>, ast::
         if CRATES.get(krate).is_none() {
             eprintln!("Parsing crate {krate}");
             std::process::Command::new("rustup")
-                .args(["install", "nightly-2024-07-23"])
+                .args(["install", "nightly-2025-02-17"])
                 .output()
                 .expect("failed to install nightly");
             let output = std::process::Command::new("rustup")
                 .args([
                     "run",
-                    "nightly-2024-07-23",
+                    "nightly-2025-02-17",
                     "cargo",
                     "rustdoc",
                     "-p",
@@ -186,8 +186,8 @@ fn collect_public_types(krate: &str) -> impl Iterator<Item = (Vec<String>, ast::
             return;
         }
         match &item.inner {
-            ItemEnum::Import(import) => {
-                if !import.glob {
+            ItemEnum::Use(import) => {
+                if !import.is_glob {
                     path.push(import.name.clone());
                 }
 
@@ -235,7 +235,7 @@ fn collect_public_types(krate: &str) -> impl Iterator<Item = (Vec<String>, ast::
                                     .iter()
                                     .map(|id| &external_crate.index[id])
                                     .find(|item| match &item.inner {
-                                        ItemEnum::Import(import) => {
+                                        ItemEnum::Use(import) => {
                                             if import.name.as_str() == segment {
                                                 path.pop();
                                                 true
@@ -272,11 +272,10 @@ fn collect_public_types(krate: &str) -> impl Iterator<Item = (Vec<String>, ast::
                             if let ItemEnum::Impl(inner) = &krate.index[id].inner {
                                 let mut trait_name = None;
                                 if let Some(path) = &inner.trait_ {
-                                    let name = &path.name;
-                                    if IGNORED_TRAITS.contains(name.as_str()) {
+                                    if IGNORED_TRAITS.contains(path.path.as_str()) {
                                         continue;
                                     }
-                                    trait_name = Some(&*path.name);
+                                    trait_name = Some(path.path.as_str());
                                 }
                                 for id in &inner.items {
                                     recurse(
@@ -302,11 +301,10 @@ fn collect_public_types(krate: &str) -> impl Iterator<Item = (Vec<String>, ast::
                             if let ItemEnum::Impl(inner) = &krate.index[id].inner {
                                 let mut trait_name = None;
                                 if let Some(path) = &inner.trait_ {
-                                    let name = &path.name;
-                                    if IGNORED_TRAITS.contains(name.as_str()) {
+                                    if IGNORED_TRAITS.contains(path.path.as_str()) {
                                         continue;
                                     }
-                                    trait_name = Some(&*path.name);
+                                    trait_name = Some(path.path.as_str());
                                 }
                                 for id in &inner.items {
                                     recurse(

tools/make/diplomat-coverage/src/main.rs

@@ -22,9 +22,9 @@ ALL_RUST_SRC = $(wildcard ../../../components/**/*.rs) $(wildcard ../../../provi
 $(ALL_HEADERS):
 
 GCC := gcc
-CLANG := clang-18
-LLD := lld-18
-LLVM_COMPATIBLE_NIGHTLY = "nightly-2024-07-01"
+CLANG := clang-19
+LLD := lld-19
+LLVM_COMPATIBLE_NIGHTLY = "nightly-2025-02-17"
 
 
 target/release/icu4x-datagen: $(ALL_RUST_SRC)

tutorials/c-tiny/README.md

@@ -22,9 +22,9 @@ ALL_RUST_SRC = $(wildcard ../../../components/**/*.rs) $(wildcard ../../../provi
 $(ALL_HEADERS):
 
 GCC := gcc
-CLANG := clang-18
-LLD := lld-18
-LLVM_COMPATIBLE_NIGHTLY = "nightly-2024-07-01"
+CLANG := clang-19
+LLD := lld-19
+LLVM_COMPATIBLE_NIGHTLY = "nightly-2025-02-17"
 
 
 target-normal/release/libicu_capi.a:

tutorials/c-tiny/fixeddecimal/Makefile

@@ -9,7 +9,7 @@ ICU_CAPI := $(shell cargo metadata --format-version 1 | jq '.packages[] | select
 HEADERS := ${ICU_CAPI}/bindings/js
 ALL_HEADERS := $(wildcard ${HEADERS}/*)
 
-LLVM_COMPATIBLE_NIGHTLY ?= "nightly-2024-07-01"
+LLVM_COMPATIBLE_NIGHTLY ?= "nightly-2025-02-17"
 
 $(ALL_HEADERS):
 

tutorials/c-tiny/segmenter/Makefile

@@ -32,7 +32,7 @@ def main():
         else:
             new_argv += [arg]
             is_export = False
-    result = subprocess.run(["lld-18"] + new_argv, stdout=sys.stdout, stderr=sys.stderr)
+    result = subprocess.run(["lld-19"] + new_argv, stdout=sys.stdout, stderr=sys.stderr)
     return result.returncode
 
 if __name__ == "__main__":

tutorials/js-tiny/Makefile

@@ -4,7 +4,7 @@
 
 export CARGO_TARGET_DIR ?= target
 
-PINNED_CI_NIGHTLY = "nightly-2024-07-23"
+PINNED_CI_NIGHTLY = "nightly-2025-02-17"
 
 all: buffer_data.postcard bin/tutorial_buffer.wasm