Skip to content

Make LLMCharacter extendable #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3inary opened this issue Sep 10, 2024 · 1 comment · Fixed by #239
Closed

Make LLMCharacter extendable #235

3inary opened this issue Sep 10, 2024 · 1 comment · Fixed by #239
Labels
enhancement New feature or request

Comments

@3inary
Copy link

3inary commented Sep 10, 2024

Describe the feature

Hi, i'd like to be able to define the json save (for ex. add a title) and to do so override the Load/Save functions.
To make this possible some signatures need to be modified in LLMCharacter:

protected string GetSavePath(string filename)
protected string GetJsonSavePath(string filename)
protected string GetCacheSavePath(string filename)
public/protected virtual async Task Save(string filename)
public/protected virtual async Task Load(string filename)
// protected async Task Slot(string filepath, string action)

And in LLMCharacterEditor:
[CustomEditor(typeof(LLMCharacter), true)] // set to true to accept child classes as well

@3inary 3inary added the enhancement New feature or request label Sep 10, 2024
@amakropoulos
Copy link
Collaborator

Sure, will do that for the next release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants