Skip to content

Commit baf7086

Browse files
authored
fix: PluginConfig should use classic config (#259)
1 parent 973985e commit baf7086

File tree

6 files changed

+14
-11
lines changed

6 files changed

+14
-11
lines changed

.changeset/giant-teachers-switch.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"eslint-plugin-import-x": patch
3+
---
4+
5+
fix: `PluginConfig` should use classic config

src/config/react.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ export = {
1111
settings: {
1212
'import-x/extensions': ['.js', '.jsx'],
1313
},
14-
languageOptions: {
15-
parserOptions: {
16-
ecmaFeatures: {
17-
jsx: true,
18-
},
14+
parserOptions: {
15+
ecmaFeatures: {
16+
jsx: true,
1917
},
2018
},
2119
} satisfies PluginConfig

src/types.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ export type PluginSettings = WithPluginName<ImportSettings>
114114
export type PluginConfig = {
115115
plugins?: [PluginName]
116116
settings?: PluginSettings
117-
rules?: Record<`${PluginName}/${string}`, TSESLint.Linter.RuleEntry>
118-
} & TSESLint.Linter.ConfigType
117+
rules?: Record<`${PluginName}/${string}`, TSESLint.ClassicConfig.RuleEntry>
118+
} & TSESLint.ClassicConfig.Config
119119

120120
export type PluginFlatBaseConfig = {
121121
settings?: PluginSettings

test/rules/no-duplicates.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
} from '../utils'
1212
import type { GetRuleModuleMessageIds, RuleRunTests } from '../utils'
1313

14-
import jsxConfig from 'eslint-plugin-import-x/config/react'
14+
import jsxConfig from 'eslint-plugin-import-x/config/flat/react'
1515
import rule from 'eslint-plugin-import-x/rules/no-duplicates'
1616

1717
const ruleTester = new TSESLintRuleTester()

test/rules/no-extraneous-dependencies.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
} from '../fixtures/package.json'
1010
import { parsers, createRuleTestCaseFunctions, testFilePath } from '../utils'
1111

12-
import typescriptConfig from 'eslint-plugin-import-x/config/typescript'
12+
import typescriptConfig from 'eslint-plugin-import-x/config/flat/typescript'
1313
import rule from 'eslint-plugin-import-x/rules/no-extraneous-dependencies'
1414

1515
const ruleTester = new TSESLintRuleTester()

test/rules/no-unused-modules.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import { RuleTester as ESLint9_FlatRuleTester } from 'eslint9'
1010
import { createRuleTestCaseFunctions, testFilePath, parsers } from '../utils'
1111
import type { GetRuleModuleOptions, GetRuleModuleMessageIds } from '../utils'
1212

13-
import jsxConfig from 'eslint-plugin-import-x/config/react'
14-
import typescriptConfig from 'eslint-plugin-import-x/config/typescript'
13+
import jsxConfig from 'eslint-plugin-import-x/config/flat/react'
14+
import typescriptConfig from 'eslint-plugin-import-x/config/flat/typescript'
1515
import rule from 'eslint-plugin-import-x/rules/no-unused-modules'
1616

1717
const ruleTester = new TSESLintRuleTester()

0 commit comments

Comments
 (0)